Closed Bug 816149 Opened 8 years ago Closed 8 years ago

When updating hosted apps with appcache, the update is automatically done

Categories

(Core Graveyard :: DOM: Apps, defect, P1)

Other
Gonk (Firefox OS)
defect

Tracking

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed)

VERIFIED FIXED
mozilla20
blocking-basecamp +
Tracking Status
firefox18 --- fixed
firefox19 --- fixed
firefox20 --- fixed

People

(Reporter: julienw, Assigned: fabrice)

References

Details

Attachments

(1 file, 2 obsolete files)

In Webapps.jsm, in updateHostedApp, we trigger automatically an update if the manifest changed.

However, we might want to ask the user first, as we do for packaged app, because we might download a lot of stuff.
blocking-basecamp: --- → ?
blocking-basecamp: ? → +
Fabrice, can you take this?
Assignee: nobody → fabrice
Summary: [Webapps] When updating hosted apps with appcache, the update is automatically done → When updating hosted apps with appcache, the update is automatically done
Attached patch patch (obsolete) — Splinter Review
Julien, can you build with this patch and check that it makes gaia happy?
I still couldn't try it yet but it seems something's missing, because you don't call |startOfflineCacheDownload| in the |startDownload| method.
oh yes, thanks, I missed that.

Will try this patch as soon as I can have a working out-of-b2g-tree gecko.
Attached patch patch v2 (obsolete) — Splinter Review
Better patch.
Attachment #686477 - Attachment is obsolete: true
Setting priority based on triage discussions.  Feel free to decrease priority if you disagree.
Priority: -- → P1
Attached patch patch v3Splinter Review
Attachment #686601 - Attachment is obsolete: true
Attachment #687424 - Flags: review?(ferjmoreno)
Attachment #687424 - Flags: review?(ferjmoreno) → review+
https://hg.mozilla.org/mozilla-central/rev/abcf9d5fd503
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Keywords: verifyme
QA Contact: jsmith
Sorry Fabrice, didn't have time to try the patch before landing.

I'm wondering if the "NOT_UPDATABLE" error will have an impact on the Gaia part.
Not working for me. See bug 824697 for a followup.
Depends on: 824697
Keywords: verifyme
Whiteboard: [qa verification blocked]
Keywords: verifyme
Whiteboard: [qa verification blocked]
Verified on 1/21 build.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.