816172 - implement gittool

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

Just like hgtool, but for git!

Comment 1

[Chris AtLee [:catlee]]

Attachment: initial gittool implementation with tests

Comment 2

[Chris AtLee [:catlee]]

Attachment: initial gittool implementation with tests

catch and throw KeyboardInterrupt when looping through mirrors so we don't just move onto the next mirror on ctrl-c

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 686189 [details] [diff] [review]
initial gittool implementation with tests

FTR, I reviewed the patch offline and catlee addressed all comments I had.

Comment 4

[Chris AtLee [:catlee]]

Attachment: support older versions of git

Comment 5

[Chris AtLee [:catlee]]

Attachment: deploy gittool.py and retry.py with puppetagain

Comment 6

[Chris AtLee [:catlee]]

Attachment: deploy gittool.py and retry.py with puppetagain

actually include the packages.

diff --git a/modules/toplevel/manifests/slave/build.pp b/modules/toplevel/manifests/slave/build.pp
index 326eb88..9570553 100644
--- a/modules/toplevel/manifests/slave/build.pp
+++ b/modules/toplevel/manifests/slave/build.pp
@@ -16,6 +16,8 @@ class toplevel::slave::build inherits toplevel::slave {
     include packages::mozilla::git
     include packages::mozilla::py27_virtualenv
     include packages::mozilla::hgtool
+    include packages::mozilla::gittool
+    include packages::mozilla::retry
 
     ccache::ccache_dir {
         "/builds/ccache":

Comment 7

[Chris AtLee [:catlee]]

Attachment: gittool support for mozharness

Comment 8

[Aki Sasaki (not active)]

Comment on attachment 687809 [details] [diff] [review]
gittool support for mozharness

I think I said this earlier, still true:

We're re-using a lot here and could potentially share more code between the hgtool and gittool implementations.  However, I'm happy to have this patch land as is, and we can revisit that when we're less pressured for time.

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

attachment 686567 [details] [diff] [review] landed yesterday, but needs docs.

Is there any particular reason that these tools were dropped in /usr/local/bin, while tooltool is in /tools?

Comment 10

[Chris AtLee [:catlee]]

Attachment: Fix git.init()

gittool was failing in staging because it was trying to delete /builds/git-shared. There's no need to completely delete the directory when we're calling init, we just need to make sure it's empty.

Comment 11

[Chris AtLee [:catlee]]

Attachment: Manage /builds/git-shared with puppet, and add to mock configs

Comment 12

[Chris AtLee [:catlee]]

(In reply to Dustin J. Mitchell [:dustin] from comment #9)
> attachment 686567 [details] [diff] [review] landed yesterday, but needs docs.

Added docs for gittool/hgtool here:
https://wiki.mozilla.org/index.php?title=ReleaseEngineering%2FPuppetAgain%2FModules%2Fpackages&action=historysubmit&diff=492534&oldid=472709

> Is there any particular reason that these tools were dropped in
> /usr/local/bin, while tooltool is in /tools?

Having tools in the default path is really handy.

Comment 13

[Chris AtLee [:catlee]]

Attachment: gittool support for mozharness

changes from last time:

- Change gittool/hgtool to look for {vcs}s_ prefixed configuration settings before looking for vcs_ (e.g. gittool_share_base vs vcs_share_base)

Comment 14

[Aki Sasaki (not active)]

Comment on attachment 690602 [details] [diff] [review]
gittool support for mozharness

I definitely want us to start looking at git_* and hg_* instead of gittool_* and hgtool_* at some point, but this looks good.