816173 - Split out WebGLFramebuffer into separate files

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

This one depends on bug 815921 (WebGLTexture) and bug 816168 (WebGLRenderbuffer) being done first. Don't start working on it before these two other bugs are fixed.

The goal is to move WebGLFramebuffer, which currently lives in WebGLContext.h, into a separate new header WebGLFramebuffer.h and move as much code as possible to the WebGLFramebuffer.cpp file.

Also, WebGLFramebuffer has a companion helper class, WebGLFramebufferAttachment. It's only used internally by WebGLFramebuffer. So I think it makes most sense to keep it in the same files, WebGLFramebuffer.{h,cpp}.

In fact, it would make sense to move WebGLFramebufferAttachment into a nested Attachment class inside of WebGLFramebuffer, so it would become WebGLFramebuffer::Attachment. Up to you.

Comment 1

[Saurabh Anand [:sawrubh]]

Attachment: Patch v1

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 688361 [details] [diff] [review]
Patch v1

Review of attachment 688361 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 3

[Saurabh Anand [:sawrubh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc3df4922144

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/cc3df4922144