816223 - Mach should find xpcshell.ini in subdirectories

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Gregory Szorc [:gps]]

From Ted's wonderful mind we have an excellent idea: mach should be able to find xpcshell.ini in subdirectories and automagically run them.

Use case: $ ./mach xpcshell-test toolkit/

This directory by itself doesn't have any tests defined or xpcshell.ini. But, plenty exist in subdirectories. If mach receives a directory argument and that directory doesn't contain an xpcshell.ini, I believe mach should os.walk into children, assemble all the xpcshell.ini, and proceed to run the tests in all of them.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Attachment: Find subdirectories which contain an xpcshell.ini

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 726724 [details] [diff] [review]
Find subdirectories which contain an xpcshell.ini

Review of attachment 726724 [details] [diff] [review]:
-----------------------------------------------------------------

As default behavior, eh? My initial reaction is that might be unexpected in some scenarios. How about only recursing if the directory does not contain an xpcshell.ini or if a -r --recursive argument is present?

Comment 3

[Georg Fritzsche [:gfritzsche]]

(In reply to Gregory Szorc [:gps] from comment #2)
> As default behavior, eh? My initial reaction is that might be unexpected in
> some scenarios. How about only recursing if the directory does not contain
> an xpcshell.ini or if a -r --recursive argument is present?

Hm, can you think of any scenarios where this matters? I couldn't, that's
why i threw away that branching.

Comment 4

[Gregory Szorc [:gps]]

Well, I guess we can push it and see if people complain!

Comment 5

[Marco Bonardo [:mak]]

good test cases is mach xpcshell-test toolkit/components/places/ or mach xpcshell-test toolkit/components/places/tests/
does it work for these?

Comment 6

[Marco Bonardo [:mak]]

fwiw, the old make was doing it by default, and that is the expected behavior imo, I hope it will be default at least if there's no xpcshell.ini

Comment 7

[Georg Fritzsche [:gfritzsche]]

(In reply to Gregory Szorc [:gps] from comment #4)
> Well, I guess we can push it and see if people complain!

Right, trivial enough to re-add if needed :)

(In reply to Marco Bonardo [:mak] from comment #5)
> good test cases is mach xpcshell-test toolkit/components/places/ or mach
> xpcshell-test toolkit/components/places/tests/
> does it work for these?

Looks good to me.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 726724 [details] [diff] [review]
Find subdirectories which contain an xpcshell.ini

Review of attachment 726724 [details] [diff] [review]:
-----------------------------------------------------------------

Sort of unfortunate that we don't use the manifests for running the tests here (given that we've located manifest files). This isn't really any worse than the existing code, but would make a good followup. I can imagine that people would see weird scenarios where we have tests disabled in the manifest, but they'll be run anyway when running "mach xpcshell-tests".

Comment 9

[(not currently active) Ted Mielczarek]

Filed bug 852959 for that followup.

Comment 10

[Georg Fritzsche [:gfritzsche]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e0747f4c9bbc

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e0747f4c9bbc

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Should use 4-space indentation, btw...

Comment 13

[(not currently active) Ted Mielczarek]

Lame. Feel free to just fix it.