816256 - Work - richgrid layouts not behaving properly

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Allison Naaktgeboren :ally]

sometimes the <richgrid>s that appears on the about:home lays out improperly. instead of being vertical rows they end up as 2 very, very long horizontal rows (instead of a couple of vertical rows in columns of 4-6), wasting a lot of screen space in landscape mode. I am mostly seeing this with recent history, but it may not be limited to that.

I notice that the behavior does not appear when running on desktop in metro mode.

It is unclear if this is a regression. juanb?

Comment 1

[Sam Foster [:sfoster] (he/him)]

I've seen this too and if its a regression it predates my joining the project as I /think/ I've seen it sporadically since (my) day 1. 

Related: https://bugzilla.mozilla.org/show_bug.cgi?id=793515

Comment 2

[Allison Naaktgeboren :ally]

We talked about how painful this is at the ux meeting yesterday. I imagine we want to add this to our mvp (as much as I don't want to add to the mvp) and make this work a priority in the upcoming iteration.

Comment 3

[Matt Brubeck (:mbrubeck)]

Agreed.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

The main bug happens because StartUI.show is called before ContentAreaObserver.update (which sets the correct width and height styles for the start container) isn't called until the first "resize" event is dispatched.  We need to make sure these are set during startup.

On a related note, the patch makes sure the navigation appbar is visible at startup, to avoid jank when it appears suddenly during the startup process.

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/projects/elm/rev/816fa14a7a42

Comment 6

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.