Closed Bug 816260 Opened 13 years ago Closed 13 years ago

[B2G][Internet Sharing] Hotspot Settings: No error message is displayed when Wi-Fi hotspot SSID is blank.

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g18+)

VERIFIED FIXED
Tracking Status
b2g18 + ---

People

(Reporter: ckreinbring, Assigned: MrDHat)

References

Details

(Whiteboard: testrun 4, leorun1, leorun4)

Attachments

(3 files)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20100101 Firefox/16.0 Build ID: 20121024073032 Steps to reproduce: Unagi version: 20121128071138 1. From the device home screen, select Settings, then Internet sharing. 2. Select Hotspot settings. 3. Select the SSID network name textbox and delete any text in it. 4. Tap the OK button in the upper right corner and observe the reaction. Actual results: The user is returned to the Internet sharing page with the Name field shown as blank. The user will be unable to activate the Wi-Fi hotspot toggle, however. Expected results: User remains in the Hotspot settings page with the error message "Create a name for the network."
Attached image Screenshot —
Status: UNCONFIRMED → NEW
Ever confirmed: true
Issue repros on Build 20130104070203 (In reference to test case 3548) Repro Steps 1. Open Settings 2. Click on Internet sharing 3. Open Hotspot settings 4. Delete SSID network name 5. Click Ok 6. View what happens Expected: Error message will display the following error text above the form: "Create a name for the network." Actual: Nothing happens. Takes you back to Internet Sharing page and shows Name/SSID as blank. Note: You are unable to have Wi-Fi Stay connected while no name is listed however no indication why you can't stay connected either.
Whiteboard: testrun 2
Repros on Unagi device Build ID: 20130115070201 using the december 5th kernel v 1.0.0-Prerelease
OS: All → Gonk (Firefox OS)
Hardware: All → ARM
Test Run 4 This is reproducing on Unagi Kernal Dec 5 Build 20130130070201
Test Run 4 This is reproducing on Build ID: 20130130070201 Kernel: Dec 5 Gecko http://hg.mozilla.org/releases/mozilla-b2g18/rev/4593f3e765eb Gaia f7f5a0cd17e3d04308cc5850b254947e127122b9
Whiteboard: testrun 2 → Testrun 4
Still repros on Unagi version 20130208070301 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/71ddeff45ec2 Gaia: cff23a80c41b7de223d27c6a6f1f82f95c9c5f6b Kernel: Dec 5
blocking-b2g: --- → leo?
Whiteboard: Testrun 4 → testrun 4
Summary: Setting the Wi-Fi hotspot SSID to blank does not generate error text → [B2G][Internet Sharing] Hotspot Settings: No error message is displayed when Wi-Fi hotspot SSID is blank.
blocking-b2g: leo? → -
tracking-b2g18: --- → +
I sent a pull a request which fixes this bug to some extent. https://github.com/mozilla-b2g/gaia/pull/8280
Pardon me for repetitive comments [Still getting familiar to bugzilla]
Attachment #717661 - Flags: review?
Still repros in Unagi build 20130312070202 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/99680a32f297 Gaia: de3e5b9205e6cb1a6bd0858a98d159272ad96d11 Kernel Date: Dec 5
Comment on attachment 717661 [details] [diff] [review] Fixed Bug 816260 - Hotspot Settings: No error message is displayed when Wi-Fi hotspot SSID is blank Kaze is the most experienced with the Settings app, asking him for review.
Attachment #717661 - Flags: review? → review?(kaze)
I have written a few demands on the github pull request. Will happily r+ this when these demands are addressed. :-)
Fixed the Linter issues. The code now passes gjslint and the Travis build, please review.
Comment on attachment 717661 [details] [diff] [review] Fixed Bug 816260 - Hotspot Settings: No error message is displayed when Wi-Fi hotspot SSID is blank Please look at my last comments on github, and squash your commits before merging. Thanks!
Attachment #717661 - Flags: review?(kaze) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
I realize this patch has left some dead code. Will submit a follow-up patch.
Attached file link to pull request —
Just a minor clean-up. Sorry I missed that in my review.
Attachment #731717 - Flags: review?(ehung)
Comment on attachment 731717 [details] link to pull request r=me.
Attachment #731717 - Flags: review?(ehung) → review+
Whiteboard: testrun 4 → testrun 4, leorun1
Still repros on Inari 1.1 commercial RIL and Leo 1.1 commercial RIL. Inari 1.1 commercial RIL Build ID: 20130531070205 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/4f318822e72c Gaia: e1c59baed29e4665d1da9392f86239272073f07a Version: 18.0 Leo 1.1 commercial RIL Build ID: 20130531070205 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/4f318822e72c Gaia: e1c59baed29e4665d1da9392f86239272073f07a Version: 18.0
Assignee: nobody → ktyaks
Whiteboard: testrun 4, leorun1 → testrun 4, leorun1, leorun4
Gecko http://hg.mozilla.org/releases/mozilla-b2g18/rev/282b5c37cf8d Gaia e2ef782119b7e79fc62c48d36f0c36909d982988 BuildID 20130712070210 Version 18.0 Still seeing this problem on the above build. Closing this bug and opening a new one because the fix for this is actually three months back.
Status: RESOLVED → VERIFIED
Blocks: 894132
Blocks: 894132
This bug is reproducible on v1-train (as detailed in comment 21 and comment 22) and bug 894132 was filed to track this -- nevertheless its fix is already on master. Requesting blocking-b2g:leo in order to have this fix uplifted to v1-train.
blocking-b2g: - → leo?
Triage - not blocking for leo release.
blocking-b2g: leo? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: