sort releases on releases.html by submission time

RESOLVED FIXED

Status

Release Engineering
Release Automation
P3
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: bhearsum, Assigned: massimo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [shipit])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Newer releases should be at the top. We already sort by pending/running/completed, we should sort by submission time within each of those categories.
(Reporter)

Comment 1

5 years ago
A few things to do here?
1) Add a submission time Column to the database.
2) Store submission time when accepting a release
3) Adjust the sort here to take it into account: http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=kickoff/views/releases.py;h=a053d88426f5a3c7734994bda15d64bfcfe7b59f;hb=HEAD#l71
(Reporter)

Comment 2

5 years ago
This is a nice to have -> P3.
Priority: -- → P3
(Reporter)

Updated

5 years ago
Whiteboard: [kickoff] → [shipit]
Bug 810411 added the submission time data. Just need to sort what we have now.
(Reporter)

Comment 4

5 years ago
Sorting is done in this method: http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=kickoff/views/releases.py;h=33463012742ba93d8d0a981d650fd744f78595ad;hb=HEAD#l12

It can be adjusted to take submission time into account. Note that submission time should be a secondary sort -- we still want ready/pending above completed.

Massimo, can you take a look at this?
Assignee: nobody → mgervasini
(Assignee)

Comment 5

5 years ago
Created attachment 719950 [details] [diff] [review]
replaced sort by name with sort by submission date.
Attachment #719950 - Flags: review?(bhearsum)
(Reporter)

Updated

5 years ago
Attachment #719950 - Flags: review?(bhearsum) → review+
(Reporter)

Comment 6

5 years ago
Comment on attachment 719950 [details] [diff] [review]
replaced sort by name with sort by submission date.

Landed. The dev environment will pick this up automatically. I'll ask for a push to stage/prod after bug 843228 is landed, so we can batch them together.
Attachment #719950 - Flags: checked-in+
(Reporter)

Updated

5 years ago
Depends on: 847516
(Reporter)

Comment 7

5 years ago
This is in production now.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
I think this got regressed at some point, or perhaps not carried over to the new datatables layout. Default sort is Name ascending now.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

5 years ago
Created attachment 732307 [details] [diff] [review]
added datatable sorting

Added sorting in datatable initialization. Updated datable css so the 'submitted at' column is not highlighted when the table loads.
Attachment #719950 - Attachment is obsolete: true
Attachment #732307 - Flags: review?(bhearsum)
(Reporter)

Comment 10

5 years ago
Comment on attachment 732307 [details] [diff] [review]
added datatable sorting

Review of attachment 732307 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I landed it right into production.
Attachment #732307 - Flags: review?(bhearsum)
Attachment #732307 - Flags: review+
Attachment #732307 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.