Closed
Bug 816284
Opened 12 years ago
Closed 11 years ago
sort releases on releases.html by submission time
Categories
(Release Engineering :: Release Automation: Other, defect, P3)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: massimo)
References
Details
(Whiteboard: [shipit])
Attachments
(1 file, 1 obsolete file)
1.09 KB,
patch
|
bhearsum
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
Newer releases should be at the top. We already sort by pending/running/completed, we should sort by submission time within each of those categories.
Reporter | ||
Comment 1•12 years ago
|
||
A few things to do here? 1) Add a submission time Column to the database. 2) Store submission time when accepting a release 3) Adjust the sort here to take it into account: http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=kickoff/views/releases.py;h=a053d88426f5a3c7734994bda15d64bfcfe7b59f;hb=HEAD#l71
Reporter | ||
Updated•11 years ago
|
Whiteboard: [kickoff] → [shipit]
Comment 3•11 years ago
|
||
Bug 810411 added the submission time data. Just need to sort what we have now.
Reporter | ||
Comment 4•11 years ago
|
||
Sorting is done in this method: http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=kickoff/views/releases.py;h=33463012742ba93d8d0a981d650fd744f78595ad;hb=HEAD#l12 It can be adjusted to take submission time into account. Note that submission time should be a secondary sort -- we still want ready/pending above completed. Massimo, can you take a look at this?
Assignee: nobody → mgervasini
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #719950 -
Flags: review?(bhearsum)
Reporter | ||
Updated•11 years ago
|
Attachment #719950 -
Flags: review?(bhearsum) → review+
Reporter | ||
Comment 6•11 years ago
|
||
Comment on attachment 719950 [details] [diff] [review] replaced sort by name with sort by submission date. Landed. The dev environment will pick this up automatically. I'll ask for a push to stage/prod after bug 843228 is landed, so we can batch them together.
Attachment #719950 -
Flags: checked-in+
Reporter | ||
Comment 7•11 years ago
|
||
This is in production now.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 8•11 years ago
|
||
I think this got regressed at some point, or perhaps not carried over to the new datatables layout. Default sort is Name ascending now.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•11 years ago
|
||
Added sorting in datatable initialization. Updated datable css so the 'submitted at' column is not highlighted when the table loads.
Attachment #719950 -
Attachment is obsolete: true
Attachment #732307 -
Flags: review?(bhearsum)
Reporter | ||
Comment 10•11 years ago
|
||
Comment on attachment 732307 [details] [diff] [review] added datatable sorting Review of attachment 732307 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, I landed it right into production.
Attachment #732307 -
Flags: review?(bhearsum)
Attachment #732307 -
Flags: review+
Attachment #732307 -
Flags: checked-in+
Assignee | ||
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•