Closed Bug 816374 Opened 7 years ago Closed 7 years ago

Don't export RasterImage from imagelib

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file, 2 obsolete files)

Since no code should be creating or interacting with RasterImages directly, we should remove RasterImage from nsImageModule.cpp and avoid exporting the class.
Preliminary patch. Waiting on 816362 before proceeding.
Requesting addon compatiblity review.
Keywords: addon-compat
Attachment #686384 - Flags: review?(joe)
Attachment #686384 - Flags: review?(joe) → review+
Updated patch to make RasterImage's constructor protected like VectorImage's and remove the associated comment. This was inadvertently left out of the original version.
Attachment #686384 - Attachment is obsolete: true
Drat; build failed on that try job due to an issue with bug 816362. That issue's been fixed. New try job here: https://tbpl.mozilla.org/?tree=Try&rev=6b5693777727
Try finished with 100% green. Requesting checkin.
Blocks: 821023
Sorry, but something in bug 815471, bug 821023, bug 816374, or bug 816362 was causing reftest failures on all platforms and Android mochitest-8 failures. See the TBPL link below. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/47bd1f6fd8ed

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=22f0a7ee5348
Rebased against tip. 100% green try run with this patch here: https://tbpl.mozilla.org/?tree=Try&rev=28875dc06b0e
Attachment #688036 - Attachment is obsolete: true
Let's try it again. Thanks for landing these, Ryan.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c243e7f3512d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.