816374 - Don't export RasterImage from imagelib

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

Since no code should be creating or interacting with RasterImages directly, we should remove RasterImage from nsImageModule.cpp and avoid exporting the class.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Don't export RasterImage from imagelib.

Preliminary patch. Waiting on 816362 before proceeding.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Requesting addon compatiblity review.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Attachment: Don't export RasterImage from imagelib.

Updated patch to make RasterImage's constructor protected like VectorImage's and remove the associated comment. This was inadvertently left out of the original version.

Comment 4

[Seth Fowler [:seth] [:s2h]]

Try job here: https://tbpl.mozilla.org/?tree=Try&rev=6247f46ae861

Comment 5

[Seth Fowler [:seth] [:s2h]]

Drat; build failed on that try job due to an issue with bug 816362. That issue's been fixed. New try job here: https://tbpl.mozilla.org/?tree=Try&rev=6b5693777727

Comment 6

[Seth Fowler [:seth] [:s2h]]

Try finished with 100% green. Requesting checkin.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb7ffa195fa5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Sorry, but something in bug 815471, bug 821023, bug 816374, or bug 816362 was causing reftest failures on all platforms and Android mochitest-8 failures. See the TBPL link below. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/47bd1f6fd8ed

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=22f0a7ee5348

Comment 9

[Seth Fowler [:seth] [:s2h]]

Attachment: Don't export RasterImage from imagelib.

Rebased against tip. 100% green try run with this patch here: https://tbpl.mozilla.org/?tree=Try&rev=28875dc06b0e

Comment 10

[Seth Fowler [:seth] [:s2h]]

Let's try it again. Thanks for landing these, Ryan.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c243e7f3512d

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c243e7f3512d