Closed
Bug 816432
Opened 12 years ago
Closed 12 years ago
Fix compiler to work with the refactored parser for 1.0
Categories
(L20n :: JS Library, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
1.0
People
(Reporter: stas, Assigned: stas)
References
Details
Attachments
(1 file)
|
102.54 KB,
patch
|
zbraniecki
:
review+
|
Details | Diff | Splinter Review |
Bug 813862 changes the Parser API and introduces a few modifications to the AST. The compiler needs to be updated accordingly. Then, we can finally move to using LOL files in the testcases instead of pre-parsed JSON files (bug 810817).
|
Assignee | |
Comment 1•12 years ago
|
||
This also fixes bug 810817, hence all the changes to the testcases. I haven't added error emitting; I'll do it in bug 802845. The actual patch is bigger because of the indentation change in compiler.js. The attached patch was produced with "git diff -b" to ignore whitespace changes.
Attachment #687010 -
Flags: review?(gandalf)
|
|
Assignee | |
Updated•12 years ago
|
Target Milestone: --- → 1.0
|
||
Comment 2•12 years ago
|
||
Comment on attachment 687010 [details] [diff] [review] Updated compiler and ctx awesome, land this beauty
Attachment #687010 -
Flags: review?(gandalf) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://github.com/l20n/l20n.js/commit/99363db9d3d553f5e71ed851ad258a6a973287b1
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•