816526 - debuggerUI.searchLine should use single unicode character instead of "..."

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Francesco Lodolo [:flod]]

<!ENTITY debuggerUI.searchLine          "Jump to line...">

That "..." should be replaced by "…" for consistency within the product.

Comment 1

[Jorge Luis Mendez [:jlmendezbonini]]

Hi Victor,

Please see the attached patch that replaces "..." for "…" in gclicommands.properties and debugger.dtd. Both files under /browser/locales/en-US/chrome/browser/devtools/

Comment 2

[Jorge Luis Mendez [:jlmendezbonini]]

Attachment: Replaces ... for unicode character … for consistency

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 701975 [details] [diff] [review]
Replaces ... for unicode character … for consistency

tagging Victor for review.

Thanks for the patch, Jorge!

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 701975 [details] [diff] [review]
Replaces ... for unicode character … for consistency

Review of attachment 701975 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great. Although not necessary for this bug, thanks for also patching gclicommands.properties.
Just change the string keys as described in the comments below and I'll r+.

::: browser/locales/en-US/chrome/browser/devtools/debugger.dtd
@@ +85,5 @@
>  <!ENTITY debuggerUI.searchToken.key     "F">
>  
>  <!-- LOCALIZATION NOTE (debuggerUI.searchLine): This is the text that appears
>    -  in the source editor's context menu for the line search operation. -->
> +<!ENTITY debuggerUI.searchLine          "Jump to line…">

String changes require a different key. You can change the entity to debuggerUI.searchLine2, and make sure you update this change everywhere else it's used.

::: browser/locales/en-US/chrome/browser/devtools/gclicommands.properties
@@ +146,5 @@
>  restartFirefoxRequestCancelled=Restart request cancelled by user.
>  
>  # LOCALIZATION NOTE (restartFirefoxRestarting) A string displayed to the
>  # user when a restart has been initiated without a delay.
> +restartFirefoxRestarting=Restarting Firefox…

Need to change this key name as well.

Comment 5

[Francesco Lodolo [:flod]]

Victor, fixes like this one – i.e. you're fixing consistency, like "e-mail" vs "email", "webpage" vs "web page", or typos in English – don't necessarily require a new key.

Comment 6

[Rob Campbell [:rc] (:robcee)]

that's confusing.

I guess that's an r+ then!

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 701975 [details] [diff] [review]
Replaces ... for unicode character … for consistency

TIL :)

Comment 8

[Jorge Luis Mendez [:jlmendezbonini]]

Thanks everyone for your comments. I'm slightly confuse though. Is there anything else to be done on my part to close this simple bug?

Comment 9

[Francesco Lodolo [:flod]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #6)
> that's confusing.

https://developer.mozilla.org/en-US/docs/Making_String_Changes

The idea is that you need some way to alert localizers if you change the meaning of a string, and that's done by changing the id (new key -> compare-locales fails -> you can't miss that). Not every tool used by localizers is able to catch a change in the content of the string, I believe that some localize using a text editor and rely on compare-locales to know what to do.

Comment 10

[Victor Porof [:vporof][:vp]]

(In reply to Jorge Luis Mendez from comment #8)
> Thanks everyone for your comments. I'm slightly confuse though. Is there
> anything else to be done on my part to close this simple bug?

You don't need to do anything else, your patch was perfect, I r+ed it. I was wrong in assuming that you need to change the entity names. Thank you for your contribution!

Comment 11

[Victor Porof [:vporof][:vp]]

(In reply to Francesco Lodolo [:flod] from comment #9)

I'm pretty sure I've seen cases in which a key change was requested/required even when only changing the meaning of a string. I suppose everything is relative to the flexibility of interpreting what "changing the meaning" means :)

Are key changes, therefore, not required when changing a word with a synonym? Or only when fixing typos and consistency (like described in comment #5)?

Comment 12

[Francesco Lodolo [:flod]]

(In reply to Victor Porof [:vp] from comment #11)
> Are key changes, therefore, not required when changing a word with a
> synonym? Or only when fixing typos and consistency (like described in
> comment #5)?

CCing also Axel here for some insight.

IMO chancing a noun with a synonym is like fixing grammar, you don't need to change the key name (you can obviously do it, but it's not mandatory). As you said it's not always clear... Does this change the sentence so that the meaning could be reinterpreted? In case of doubt just change the key and you can't be wrong :-)

Comment 13

[Axel Hecht [:Pike]]

The real question is "do I want localizations to follow" or "the stuff they have is as good as it's gonna get".

This is of course a large area of gray, large enough to get even colorful.

Changing the noun to a synonym can change the tone of a message, and if it did, it'd make sense to communicate that out.

The idea to not change the string always is that there are decisions that can be made once, but don't need to be made 100 times. Like spelling bokmarks right.

Comment 14

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/096f7f5bac91

Comment 15

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/096f7f5bac91