816551 - PluginHelper._getBindingType doesn't always return a value

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Seen in logcat on Fennec startup:

11-29 19:18:17.028 E/GeckoConsole( 1697): [JavaScript Warning: "TypeError: anonymous function does not always return a value" {file: "chrome://browser/content/browser.js" line: 5920 column: 8 source: "        return "PluginNotFound";
11-29 19:18:17.028 E/GeckoConsole( 1697): "}]
11-29 19:18:17.028 E/GeckoConsole( 1697): [JavaScript Warning: "TypeError: anonymous function does not always return a value" {file: "chrome://browser/content/browser.js" line: 5922 column: 8 source: "        return "PluginClickToPlay";
11-29 19:18:17.028 E/GeckoConsole( 1697): "}]
11-29 19:18:17.036 E/GeckoConsole( 1697): [JavaScript Warning: "TypeError: anonymous function does not always return a value" {file: "chrome://browser/content/browser.js" line: 5924 column: 8 source: "        return "PluginPlayPreview";
11-29 19:18:17.036 E/GeckoConsole( 1697): "}]
11-29 19:18:17.036 E/GeckoConsole( 1697): [JavaScript Warning: "TypeError: anonymous function does not always return a value" {file: "chrome://browser/content/browser.js" line: 5927 column: 8 source: "        return;
11-29 19:18:17.036 E/GeckoConsole( 1697): "}]

Comment 1

[:Margaret Leibovic]

We can change _getBindingType to return an empty string where it currently returns nothing:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#5934

Also, the warnings mention that this is an anonymous function. kats, I thought you said that the JS engine is smart enough now to give more useful messages for anonymous functions that are properties of objects. Is that just true for a different case?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(In reply to Margaret Leibovic [:margaret] from comment #1)
> Also, the warnings mention that this is an anonymous function. kats, I
> thought you said that the JS engine is smart enough now to give more useful
> messages for anonymous functions that are properties of objects. Is that
> just true for a different case?

According to bug 805904, the JS engine can only infer names in some cases, unfortunately.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

FWIW the desktop fix for this was to return null (see bug 814383). We should really factor this code out into a JS module reusable by both fennec and firefox...

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Sorry, this is annoying me too much, and makes it harder to spot any other warnings that might crop up on startup.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb65298e7117

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fb65298e7117