Closed
Bug 816557
Opened 13 years ago
Closed 13 years ago
Fix CORS support for Mozpool
Categories
(Testing Graveyard :: Mozpool, defect)
Testing Graveyard
Mozpool
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
Details
Attachments
(1 file)
|
1.56 KB,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
This isn't working. The symptom is a JS alert about an error on the first operation you perform on a page, although the operation succeeds.
The first attempt was to list all known imaging servers as origins in the Access-Control-Allow-Origin header, separated by space. This turned out to be a mis-reading of the docs.
The next attempt was to send a separate header for each origin. This didn't work, either.
The third attempt is to look at the Origin header from a browser *before* processing the request. If it's OK, proceed and return "Access-Control-Allow-Origin: *". If it's not OK, don't perform the action.
| Assignee | ||
Comment 1•13 years ago
|
||
Attachment #697047 -
Flags: review?(mcote)
Comment 2•13 years ago
|
||
Comment on attachment 697047 [details] [diff] [review]
bug816557.patch
Review of attachment 697047 [details] [diff] [review]:
-----------------------------------------------------------------
Cool, that works. I see you actually still return the specific origin, and not * like in comment #0, but this way is better.
Attachment #697047 -
Flags: review?(mcote) → review+
| Assignee | ||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•