Closed Bug 816557 Opened 13 years ago Closed 13 years ago

Fix CORS support for Mozpool

Categories

(Testing Graveyard :: Mozpool, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

Details

Attachments

(1 file)

This isn't working. The symptom is a JS alert about an error on the first operation you perform on a page, although the operation succeeds. The first attempt was to list all known imaging servers as origins in the Access-Control-Allow-Origin header, separated by space. This turned out to be a mis-reading of the docs. The next attempt was to send a separate header for each origin. This didn't work, either. The third attempt is to look at the Origin header from a browser *before* processing the request. If it's OK, proceed and return "Access-Control-Allow-Origin: *". If it's not OK, don't perform the action.
Attached patch bug816557.patchSplinter Review
Attachment #697047 - Flags: review?(mcote)
Comment on attachment 697047 [details] [diff] [review] bug816557.patch Review of attachment 697047 [details] [diff] [review]: ----------------------------------------------------------------- Cool, that works. I see you actually still return the specific origin, and not * like in comment #0, but this way is better.
Attachment #697047 - Flags: review?(mcote) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: