816563 - Dialer and Call Log do not have access to phone numbers from FB Contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Jose Manuel Cantera]

Dialer and Call Log should properly display names and photos when phone numbers correspond to FB Contacts.

Comment 1

[alberto.pastor]

So Dialer do have access to the FB Contacts (as both are the Communications app) but is not using it, right?

Comment 2

[Jose Manuel Cantera]

yes, that's right, we need to enable it

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Jose M. Cantera from comment #2)
> yes, that's right, we need to enable it

Since you didn't assign yourself to this bug I want to check: Are you going to work on it this week or does this bug needs to be re-assigned to someone else?

Comment 4

[Jose Manuel Cantera]

yes, I'm gonna work on that

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Any ETA / Do you need anything ?

Comment 6

[alberto.pastor]

I think JM is on holidays today so, I'm going to steal it :)

Comment 7

[Jose Manuel Cantera]

ok, alberto I'm looking forward to the patch ;) 

thanks!

Comment 8

[alberto.pastor]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6933

Pointer to Github pull-request

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Alberto Pastor from comment #8)
> Created attachment 690587 [details]
> Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6933
> 
> Pointer to Github pull-request

Does this code initialize the FB frame in the oncall.html page? If yes we should do something to not regress the call screen performance. If not that's good :)

Comment 10

[Faramarz Rashed]

lets get this landed guys.  this was a C2 bug and we're a day past that.

Comment 11

[alberto.pastor]

I will finish it in a while. It will be landed soon. Sorry for the delay

Comment 12

[Jose Manuel Cantera]

Attachment: Pointer to GH PR 6970

the PR contains code developed both by Alberto and myself.

Comment 13

[Jose Manuel Cantera]

R+ on my side for the Alberto's developed parts

Comment 14

[Jose Manuel Cantera]

once we get Alberto's R+ on my parts we can land. Unfortunately Alberto is still sleeping. David, Faramarz I can land it now if needed, it is working.

Comment 15

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/c1b69a23251a22380769e61cfb1ddfb6e7882cb1

Comment 16

[sarsenyev]

Reviewed and verified on "Unagi"
Build ID:20130103070201

Dialer and Call Log properly display names and photos when phone numbers correspond to FB Contacts.