816575 - undefined reference to 'webrtc::SetRenderAndroidVM

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Gian-Carlo Pascutto [:gcp]]

/home/morbo/hg/mozilla-central/media/webrtc/trunk/src/video_engine/vie_impl.cc:219: error: undefined reference to 'webrtc::SetRenderAndroidVM(void*)'

<derf> I suspect that block needs to be wrapped in a
<derf> #ifdef WEBRTC_VIDEO_ENGINE_RENDER_API
<derf> (the other one should be wrapped in #ifdef #ifdef WEBRTC_VIDEO_ENGINE_CAPTURE_API
<derf> ... but that's not a problem for us)

Comment 1

[Timothy B. Terriberry (:derf)]

Sorry, the first #ifdef should actually be for WEBRTC_INCLUDE_INTERNAL_VIDEO_RENDER.

For the second #ifdef, it doesn't look like there actually _is_ a define triggered off of include_internal_video_capture, which controls compilation of the definition of SetCaptureAndroidVM(). This isn't actually a problem for us, because we always use the interal capture API, but is definitely broken.

Please file an issue upstream.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Fix compiling with external video renderer

This looks similar to WebRTC issue 486.

Comment 3

[Timothy B. Terriberry (:derf)]

Comment on attachment 686658 [details] [diff] [review]
Patch 1. Fix compiling with external video renderer

Review of attachment 686658 [details] [diff] [review]:
-----------------------------------------------------------------

Perhaps would be better to use the patch from <http://code.google.com/p/webrtc/issues/detail?id=486>, but this one seems fine to me, too.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Note: patch needs upstreaming

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Sorry, I meant to say "doesn't need upstreaming"

Comment 6

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ee7c79e2ff0

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9ee7c79e2ff0