816646 - [Facebook] Better error messaging needed when you want to import contacts (no data or wifi)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of issue

Seen while running unagi:

Gaia: 1910ebaae9bda968f7da6b0ed42eef906013af30
Gecko: 72dbb825d86b5d003929c3ee1efe1187abd3646e

STR:
1. Do not import any Facebook contacts during first run
2. Go to Contacts and click settings

Expected: I could enable Facebook and add contacts
Actual: The option is completely greyed out - see screenshot

I tried going back in the Developer panel and running through the first run experience, and the option is greyed out there as well.

Comment 1

[Marcia Knous [:marcia]]

Oddly, after I raised the severity of this, the option is now available again for some reason. One thing that I did do was delete all of my existing contacts.

Comment 2

[Marcia Knous [:marcia]]

So I believe this likely happened at a moment when my wifi connection was dropped, but at the time I believed I was still connected or at least had data enabled. I am sure because of the order we run the smoketests that I did not explicitly have wifi turned off at this point. Would be good to have some error messaging if we are not detecting a wifi or data connection in this case.

Comment 3

[Dylan Oliver [:doliver]]

Confirmed that the FB option enables/disables based on data connection.

Marking b-b? for triage.

Comment 4

[Jose Manuel Cantera]

this is not a bug. Please close this.

Comment 5

[Dylan Oliver [:doliver]]

blocking- 

Removing smoketest, we won't block on adding an error/warning message here.

Comment 6

[Marcia Knous [:marcia]]

Might be in edge case, but still could be improved IMO - I was connected to wifi, the connection dropped, and I had no idea as a user that I was disconnected. We do offer network connection unavailable messages in other parts of the phone UI such as marketplace, so just pointing this out. 

If you want the bug to be closed, it should be resolved as won't fix.

Comment 7

[Jose Manuel Cantera]

Marcia,

When there is a connection error we show a dialog indicating that. What is your suggestion, to make the message more user-friendly?

Comment 8

[ayman maat :maat]

Hey guys

This bug has been raised somewhere else ages ago, and i have already written copy for it.

trying to find it...

Comment 9

[ayman maat :maat]

Ok, found it. However sorry, the bug was not raised here in Bugzilla.. but here is what was specified:

If there is no wifi or 3G connection show CTA: "import from facebook". Ensure that the "import from facebook" CTA is disabled to prevent users from dealing with an error message when they try to import from facebook but no connection to wifi/3G is detected. Below the disabled CTA inform and orientate the user as to why it is disabled by outputting the following copy: "Offline. To import Facebook contacts connect to WiFi or data network"

Comment 10

[Jose Manuel Cantera]

that's already implemented. the FB import is disabled if not network connection is available

Comment 11

[ayman maat :maat]

(In reply to Jose M. Cantera from comment #10)
> that's already implemented. the FB import is disabled if not network
> connection is available

...but the accompanying orientation message below the disabled CTA of "Offline. To import Facebook contacts connect to WiFi or data network" is still missing, no?

Comment 12

[Jose Manuel Cantera]

we have never had any visual specifying that

Comment 13

[ayman maat :maat]

(In reply to Jose M. Cantera from comment #12)
> we have never had any visual specifying that

ok Jose, i am sorry about that. I know that Vicky was working on the Visual Design for this so i will RFI her to enquire where it is...

Comment 14

[Victoria Gerchinhoren [:vicky]]

Are you talking about error messages? Shouldn't this be an overlay asking you to go and connect? Can you Ayman provide those IA specs. Thanks!

Comment 15

[Maria Angeles Oteo (:oteo)]

(In reply to Victoria Gerchinhoren from comment #14)
> Are you talking about error messages? Shouldn't this be an overlay asking
> you to go and connect? Can you Ayman provide those IA specs. Thanks!

Hi Victoria,
Ayman is refering to those orientation messages we were talking by e-mail, so when no connection (WI-Fi or 3G) apart of the disabilitation of the "FB Import" button a message should be shown to the user "Offline. To import Facebook contacts connect to WiFi or data network" (Instead of "Not imported yet") 
Can you verify the message fit in the screen?

Comment 16

[ayman maat :maat]

RFI to Victoria again referencing comment #15 and comment #9

Comment 17

[Victoria Gerchinhoren [:vicky]]

Attachment: Shows how the message fits in the screen leayout

Comment 18

[Victoria Gerchinhoren [:vicky]]

Attachment: SHows error scenario where by the user needs to click on update password btn

Comment 19

[Sergi]

Attachment: Screenshot of No Connection (WiFi/Data) Scenario

Here's a sample on how the "Import Contacts" screen will look like when there's no connection available. As you will see the switch is disabled by changing the opacity of the component (30%), and a message will indicate why the selectors are disabled. This behavior should be consistent both in Import Contacts and FTU.

Comment 20

[Jose Manuel Cantera]

just only renominating to get attention and the tracking-b2g flag.

Comment 21

[David Scravaglieri [:scravag]]

We would take a patch for this.

Comment 22

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot of the issue

See Screenshot.  We get some funky wording that doesn't fit the screen well and a URL

Comment 23

[Jose Manuel Cantera]

(In reply to Naoki Hirata :nhirata from comment #22)
> Created attachment 700390 [details]
> screenshot of the issue
> 
> See Screenshot.  We get some funky wording that doesn't fit the screen well
> and a URL

Naoki, that's a different problem and a different bug, which is that the window.open error messaging should not be displaying the concerned URL because it can be long and annoy the user. You can open another one for that problem. 

thanks!

Comment 24

[Jose Manuel Cantera]

Attachment: Pointer to GH PR 7541

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: UX will be worse
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): Low

Comment 25

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 700916 [details]
Pointer to GH PR 7541

No risky change, please merge once l10n reviewers approve

Comment 26

[Axel Hecht [:Pike]]

Comment on attachment 700916 [details]
Pointer to GH PR 7541

Grabbing the review from stas.

https://etherpad.mozilla.org/gaia-copy-guidelines says we should use "Wi-Fi", please update the string to use that instead of Wifi?

With that, r=me.

Comment 27

[Jose Manuel Cantera]

The suggested literal change has been implemented, thus merging this bug.

Comment 28

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/a71163a4c586919529484c0cfef13bfde8aebe1a

Comment 29

[Delphine Lebédel [:delphine - Use needinfo]]

Verified fixed in 2013-02-05-07-02-01 pvt nightly b2g18 build