Need to move OS/2 locking code from header to functions

VERIFIED FIXED in 4.2

Status

NSPR
NSPR
P1
major
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: mkaply, Assigned: larryh (gone))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
Currently on OS/2, the locking code is #defined in a 
header. We need to move it to os2cv.c so that we can 
implement more efficient locking.

Diff attached.

Note this depends on 79733. These changes do NOT build 
without that change. They get an unresolved error in the 
link.
(Reporter)

Comment 1

17 years ago
Created attachment 35157 [details] [diff] [review]
Move locking code to os2cv.c
(Reporter)

Updated

17 years ago
Depends on: 79733
(Reporter)

Comment 2

17 years ago
I need to up the severity on this.

We have new semaphore code that we want to drop that improves OS/2 performance 
big time.

It relies on this bug and 79733.
Severity: normal → major

Comment 3

17 years ago
I reviewed the attached patch.  It is good.

Larry, could you please check in this patch too?
(On both the NSPR trunk and the NSPRPUB_CLIENT_BRANCH.)
Assignee: wtc → larryh
Priority: -- → P1
Target Milestone: --- → 4.2
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 4

17 years ago
Checked in parts on the tip of tree.
pr/include/md/_os2.h
pr/src/md/os2/os2cv.c
(Assignee)

Comment 5

17 years ago
parts reviewed by wtc, larryh.
Checked in parts on NSPRPUB_CLIENT_BRANCH
(Assignee)

Comment 6

17 years ago
marking fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

17 years ago
Verify fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.