81666 - Need to move OS/2 locking code from header to functions

Status: VERIFIED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Mike Kaply [:mkaply]]

Currently on OS/2, the locking code is #defined in a 
header. We need to move it to os2cv.c so that we can 
implement more efficient locking.

Diff attached.

Note this depends on 79733. These changes do NOT build 
without that change. They get an unresolved error in the 
link.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Move locking code to os2cv.c

Comment 2

[Mike Kaply [:mkaply]]

I need to up the severity on this.

We have new semaphore code that we want to drop that improves OS/2 performance 
big time.

It relies on this bug and 79733.

Comment 3

[Wan-Teh Chang]

I reviewed the attached patch.  It is good.

Larry, could you please check in this patch too?
(On both the NSPR trunk and the NSPRPUB_CLIENT_BRANCH.)

Comment 4

[larryh (gone)]

Checked in parts on the tip of tree.
pr/include/md/_os2.h
pr/src/md/os2/os2cv.c

Comment 5

[larryh (gone)]

parts reviewed by wtc, larryh.
Checked in parts on NSPRPUB_CLIENT_BRANCH

Comment 6

[larryh (gone)]

marking fixed.

Comment 7

[Mike Kaply [:mkaply]]

Verify fixed