816697 - Page up/down buttons jitter when mouse pointer is on edge of button

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[Daniel]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20.0 Firefox/20.0
Build ID: 20121128030742

Steps to reproduce:

Placed mouse pointer on edge of page up/down button in pdf.js


Actual results:

The hover state jitters.

Comment 1

[Manuela Muntean [Away]]

I can't reproduce the issue with the latest Nightly.

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:20.0) Gecko/20121203 Firefox/20.0
Build ID: 20121203030801

Comment 2

[Daniel]

Attachment: screen capture of bug

The jittering only appears when hovernig over the bottom border

Comment 3

[Manuela Muntean [Away]]

(In reply to Daniel from comment #2)
> Created attachment 688294 [details]
> screen capture of bug
> 
> The jittering only appears when hovernig over the bottom border

Thank you very much for your screen capture Daniel. Unfortunatelly, I still can't reproduce the problem. Even after loading the exact pdf you are, the jittering doesn't appear.

I've tried with the latest Nightly.

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:20.0) Gecko/20121211 Firefox/20.0
Build ID: 20121211030855

Could you please try the following:

1) try this with a clean profile: http://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

2) running in Safe mode: http://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Comment 4

[Daniel]

It's reproducible with a clean profile and in safe mode as well. I think I've found the issue though. 

Row 523-524 of "viewer.css" under .splitToolbarButton:hover > .splitToolbarButtonSeparator should be 
  padding: 12px 0;
  margin: 1px 0;
instead of 
  padding: 12px 0;
  margin: 0;

The default state is 
  padding: 8px 0;
  margin: 5px 0;

Which is one pixel more than the current style for :hover
  8 + 5 != 12 + 0

There should be one px margin as well

Comment 5

[Manuela Muntean [Away]]

(In reply to Daniel from comment #4)
> It's reproducible with a clean profile and in safe mode as well. I think
> I've found the issue though. 
> 
> Row 523-524 of "viewer.css" under .splitToolbarButton:hover >
> .splitToolbarButtonSeparator should be 
>   padding: 12px 0;
>   margin: 1px 0;
> instead of 
>   padding: 12px 0;
>   margin: 0;
> 
> The default state is 
>   padding: 8px 0;
>   margin: 5px 0;
> 
> Which is one pixel more than the current style for :hover
>   8 + 5 != 12 + 0
> 
> There should be one px margin as well

If you make this changes, does this work for you?

Comment 6

[Daniel]

(In reply to Manuela Muntean from comment #5)
> (In reply to Daniel from comment #4)
> > It's reproducible with a clean profile and in safe mode as well. I think
> > I've found the issue though. 
> > 
> > Row 523-524 of "viewer.css" under .splitToolbarButton:hover >
> > .splitToolbarButtonSeparator should be 
> >   padding: 12px 0;
> >   margin: 1px 0;
> > instead of 
> >   padding: 12px 0;
> >   margin: 0;
> > 
> > The default state is 
> >   padding: 8px 0;
> >   margin: 5px 0;
> > 
> > Which is one pixel more than the current style for :hover
> >   8 + 5 != 12 + 0
> > 
> > There should be one px margin as well
> 
> If you make this changes, does this work for you?

yes

Comment 7

[Manuela Muntean [Away]]

(In reply to Daniel from comment #6)
> (In reply to Manuela Muntean from comment #5)
> > (In reply to Daniel from comment #4)
> > > It's reproducible with a clean profile and in safe mode as well. I think
> > > I've found the issue though. 
> > > 
> > > Row 523-524 of "viewer.css" under .splitToolbarButton:hover >
> > > .splitToolbarButtonSeparator should be 
> > >   padding: 12px 0;
> > >   margin: 1px 0;
> > > instead of 
> > >   padding: 12px 0;
> > >   margin: 0;
> > > 
> > > The default state is 
> > >   padding: 8px 0;
> > >   margin: 5px 0;
> > > 
> > > Which is one pixel more than the current style for :hover
> > >   8 + 5 != 12 + 0
> > > 
> > > There should be one px margin as well
> > 
> > If you make this changes, does this work for you?
> 
> yes

Comment 8

[Daniel]

Why was this bug closed? The problem is still there. Should I open an issue on https://github.com/mozilla/pdf.js instead?

Comment 9

[Daniel]

Fixed this bug over at github. See https://github.com/mozilla/pdf.js/pull/2467

Please mark this bug as fixed

Comment 10

[Daniel]

As per https://bugzilla.mozilla.org/page.cgi?id=fields.html#resolution the resolution should not be WORKSFORME since code were changed and accepted to fix this bug.

See comment 9