816747 - Add dummy POD for unPODded methods

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, enhancement)

Description

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Bug 784072 needs POD for all methods in order to be useful. The attached patch adds dummy POD for currently unPODded methods.

The dummy POD is entirely empty for each method, so Pod::Coverage introduced by bug 784072 should not use the nonwhitespace option.

Comment 1

[Frédéric Buclin]

Comment on attachment 686825 [details] [diff] [review]
Patch

With your patch, t/011pod.t throws a lot of:

*** WARNING: =head2 without preceding higher level at line 4300 in file Bugzilla/Bug.pm

Make sure to run |runtests.pl -v 11| to see these warnings.

Comment 2

[Marc Schumann [:Wurblzap]]

What, you deny review because of this?? This is dummy POD generated by a script, so that your other patch can get in. Generated POD from this is just fine. What's the problem here? We need tidy-up bugs for PODding anyway, so this can be cleaned up there, don't you think?

Comment 3

[Frédéric Buclin]

(In reply to Marc Schumann [:Wurblzap] from comment #2)
> What, you deny review because of this?? This is dummy POD generated by a
> script, so that your other patch can get in. Generated POD from this is just
> fine. What's the problem here? We need tidy-up bugs for PODding anyway, so
> this can be cleaned up there, don't you think?

The problem is that these warnings make Tinderbox to turn orange. So this doesn't help. Your patch doesn't make my code to throw these warnings. It's the existing code in 011pod.t which complains.

Comment 4

[Marc Schumann [:Wurblzap]]

Okay, does s/head2/head1/g help?

Comment 5

[Frédéric Buclin]

(In reply to Marc Schumann [:Wurblzap] from comment #4)
> Okay, does s/head2/head1/g help?

Yes, all warnings are now gone.

Comment 6

[Marc Schumann [:Wurblzap]]

All right, so please r+ this and I'll do the replacement on check-in.

Comment 7

[Frédéric Buclin]

Attachment: patch, v2

I replaced all head2 by head1 in your patch to confirm this was working fine. So here is the updated patch, so that you don't need to bother doing it yourself. :) r=LpSolit

Comment 8

[Marc Schumann [:Wurblzap]]

Thanks. Had it done already, while waiting for your answer ;)

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla.pm
modified Bugzilla/Attachment.pm
modified Bugzilla/Bug.pm
modified Bugzilla/BugMail.pm
modified Bugzilla/BugUrl.pm
modified Bugzilla/CGI.pm
modified Bugzilla/Chart.pm
modified Bugzilla/Classification.pm
modified Bugzilla/Comment.pm
modified Bugzilla/Component.pm
modified Bugzilla/Config.pm
modified Bugzilla/Constants.pm
modified Bugzilla/DB.pm
modified Bugzilla/Extension.pm
modified Bugzilla/Field.pm
modified Bugzilla/Flag.pm
modified Bugzilla/FlagType.pm
modified Bugzilla/Group.pm
modified Bugzilla/Install.pm
modified Bugzilla/JobQueue.pm
modified Bugzilla/Keyword.pm
modified Bugzilla/Mailer.pm
modified Bugzilla/Migrate.pm
modified Bugzilla/Milestone.pm
modified Bugzilla/Object.pm
modified Bugzilla/Product.pm
modified Bugzilla/RNG.pm
modified Bugzilla/Report.pm
modified Bugzilla/Search.pm
modified Bugzilla/Series.pm
modified Bugzilla/Status.pm
modified Bugzilla/Template.pm
modified Bugzilla/Token.pm
modified Bugzilla/User.pm
modified Bugzilla/Util.pm
modified Bugzilla/Version.pm
modified Bugzilla/WebService.pm
modified Bugzilla/Attachment/PatchReader.pm
modified Bugzilla/Auth/Verify.pm
modified Bugzilla/Config/Common.pm
modified Bugzilla/DB/Mysql.pm
modified Bugzilla/DB/Pg.pm
modified Bugzilla/DB/Schema.pm
modified Bugzilla/DB/Sqlite.pm
modified Bugzilla/DB/Schema/Mysql.pm
modified Bugzilla/DB/Schema/Oracle.pm
modified Bugzilla/DB/Schema/Pg.pm
modified Bugzilla/DB/Schema/Sqlite.pm
modified Bugzilla/Field/Choice.pm
modified Bugzilla/Field/ChoiceInterface.pm
modified Bugzilla/Install/CPAN.pm
modified Bugzilla/Install/Filesystem.pm
modified Bugzilla/Install/Requirements.pm
modified Bugzilla/Install/Util.pm
modified Bugzilla/Job/Mailer.pm
modified Bugzilla/JobQueue/Runner.pm
modified Bugzilla/Migrate/Gnats.pm
modified Bugzilla/Search/Clause.pm
modified Bugzilla/Search/ClauseGroup.pm
modified Bugzilla/Search/Condition.pm
modified Bugzilla/Search/Quicksearch.pm
modified Bugzilla/Search/Recent.pm
modified Bugzilla/Search/Saved.pm
modified Bugzilla/Send/Sendmail.pm
modified Bugzilla/Template/Context.pm
modified Bugzilla/WebService/Bug.pm
modified Bugzilla/WebService/Constants.pm
modified Bugzilla/WebService/Product.pm
modified Bugzilla/WebService/Server.pm
modified Bugzilla/WebService/Util.pm
modified Bugzilla/WebService/Server/JSONRPC.pm
modified Bugzilla/WebService/Server/XMLRPC.pm
modified Bugzilla/Whine/Query.pm
modified Bugzilla/Whine/Schedule.pm
Committed revision 8494.