Up-front parsing and validation of "offset" token

VERIFIED WONTFIX

Status

Cloud Services
Server: Sync
VERIFIED WONTFIX
6 years ago
4 years ago

People

(Reporter: rfkelly, Assigned: rfkelly)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

6 years ago
After the cornice-validators refactor from Bug 812432, the way that the "offset" querystring arg gets handled is pretty yuck.  We basically extract it a an opaque string and pass it to the backend, which will raise an InvalidOffsetError if it's not valid.

It would likely be cleaner to parse and validate it up-front like all the other querystring args.  Maybe not, but worth exploring.

Idea:  add a parse_offset_token() method to the storage backend that can be used to do this upfront.
We added an offset token, so done!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
(Assignee)

Comment 2

4 years ago
I agree there's no action we need to take here, but changing resolution to WONTFIX because technically, this thing this bug was about has not been done (and doesn't need to be)
Resolution: FIXED → WONTFIX
You need to log in before you can comment on or make changes to this bug.