816843 - B2G RIL: use RIL_REQUEST_DEVICE_IDENTITY to get ESN/MEID

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Edgar Chen [:edgar]]

Please reference hardware/ril/include/telephony/ril.h
RIL_REQUEST_GET_IMEI and RIL_REQUEST_GET_IMEISV are marked as deprecated.
Suggest using RIL_REQUEST_DEVICE_IDENTITY to get IMEI and IMEISV.
And we can also use RIL_REQUEST_DEIVCE_IDENTITY to get ESN and MEID. (use in CDMA)

Comment 1

[Edgar Chen [:edgar]]

I already have a WIP patch, I will take care of this bug first.
Thanks.

Comment 2

[Edgar Chen [:edgar]]

Attachment: WIP Part 1: use RIL_DEVICE_IDENTITY to get IMEI/IMEISV/ESN/MEID, v1

WIP patch

Comment 3

[Edgar Chen [:edgar]]

Attachment: WIP Part 2: modify xpcshell tests, v1

WIP patch

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Is it supported in Unagi/...?

Comment 5

[Edgar Chen [:edgar]]

Android still use RIL_REQUEST_GET_IMEI and RIL_REQUEST_GET_IMEISV to get IMEI/IMEISV, and use RIL_REQUEST_DEVICE_IDENTITY to get ESN/MEID for CDMA.
I think we can just follow the same behavior.
1). Keep the current design for IMEI and IMEISV in ril_worker.
2). Add getting ESM/MEID by using RIL_REQUEST_DEVICE_IDENTITY for CDMA.

Any other suggestion? :)

Comment 6

[Edgar Chen [:edgar]]

Attachment: use RIL_DEVICE_IDENTITY to get ESN/MEID, v2

Comment 7

[Andrew Overholt [:overholt]]

This blocks a nommed blocker so nomming here, too.

Edgar, do you need to request a review of your patch?  I mean set r? on the attachment.

Comment 8

[Andrew Overholt [:overholt]]

Comment on attachment 689658 [details] [diff] [review]
use RIL_DEVICE_IDENTITY to get ESN/MEID, v2

I'm going to guess that Thinker could help with a review here.  I could easily be totally wrong, though :)

Comment 9

[Edgar Chen [:edgar]]

Hi All,
As I mention in comment #5, for IMEI and IMEISV will still use RIL_REQUEST_GET_IMEI and RIL_REQUEST_GET_IMEIS. (Current behavior in ril_worker)

This bug now is focused on MEID/ESN which is used for CDMA.
Do you think this bug still block bug 823867? :)

Comment 10

[Shian-Yow Wu [:swu]]

Per discussion with Yoshi, bug 823867 no longer depends on this bug.
And per comment 9, this bug is targeted for CDMA phone.

Comment 11

[Johnny Stenback (:jst)]

Not blocking v1.

Comment 12

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 689658 [details] [diff] [review]
use RIL_DEVICE_IDENTITY to get ESN/MEID, v2

Review of attachment 689658 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +5768,5 @@
> +RIL[REQUEST_DEVICE_IDENTITY] = function REQUEST_DEVICE_IDENTITY(length, options) {
> +  if (!options.rilRequestError) {
> +    let result = Buf.readStringList();
> +
> +    this.ESN = result[2];

Could you have some comments about results[0] for IMEI, results[1] for IMEISV and are both ignored?

Comment 13

[Edgar Chen [:edgar]]

Attachment: use RIL_DEVICE_IDENTITY to get ESN/MEID, v3, r=vyang

1). Rebase
2). Address review comment #12

Comment 14

[Edgar Chen [:edgar]]

Attachment: use RIL_DEVICE_IDENTITY to get ESN/MEID, v4, r=vyang

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81d17e61291c

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/81d17e61291c