Closed Bug 816843 Opened 7 years ago Closed 7 years ago

B2G RIL: use RIL_REQUEST_DEVICE_IDENTITY to get ESN/MEID

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-basecamp:-)

RESOLVED FIXED
B2G C3 (12dec-1jan)
blocking-basecamp -

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file, 4 obsolete files)

Please reference hardware/ril/include/telephony/ril.h
RIL_REQUEST_GET_IMEI and RIL_REQUEST_GET_IMEISV are marked as deprecated.
Suggest using RIL_REQUEST_DEVICE_IDENTITY to get IMEI and IMEISV.
And we can also use RIL_REQUEST_DEIVCE_IDENTITY to get ESN and MEID. (use in CDMA)
I already have a WIP patch, I will take care of this bug first.
Thanks.
Assignee: nobody → echen
WIP patch
Is it supported in Unagi/...?
Android still use RIL_REQUEST_GET_IMEI and RIL_REQUEST_GET_IMEISV to get IMEI/IMEISV, and use RIL_REQUEST_DEVICE_IDENTITY to get ESN/MEID for CDMA.
I think we can just follow the same behavior.
1). Keep the current design for IMEI and IMEISV in ril_worker.
2). Add getting ESM/MEID by using RIL_REQUEST_DEVICE_IDENTITY for CDMA.

Any other suggestion? :)
Summary: B2G RIL: use RIL_REQUEST_DEVICE_IDENTITY to get IMEI/IMEISV/ESN/MEID → B2G RIL: use RIL_REQUEST_DEVICE_IDENTITY to get ESN/MEID
Attachment #688176 - Attachment is obsolete: true
Attachment #688178 - Attachment is obsolete: true
This blocks a nommed blocker so nomming here, too.

Edgar, do you need to request a review of your patch?  I mean set r? on the attachment.
blocking-basecamp: --- → ?
Comment on attachment 689658 [details] [diff] [review]
use RIL_DEVICE_IDENTITY to get ESN/MEID, v2

I'm going to guess that Thinker could help with a review here.  I could easily be totally wrong, though :)
Attachment #689658 - Flags: review?(tlee)
blocking-basecamp: ? → +
Hi All,
As I mention in comment #5, for IMEI and IMEISV will still use RIL_REQUEST_GET_IMEI and RIL_REQUEST_GET_IMEIS. (Current behavior in ril_worker)

This bug now is focused on MEID/ESN which is used for CDMA.
Do you think this bug still block bug 823867? :)
Attachment #689658 - Flags: review?(tlee) → review?(vyang)
Target Milestone: --- → B2G C3 (12dec-1jan)
Per discussion with Yoshi, bug 823867 no longer depends on this bug.
And per comment 9, this bug is targeted for CDMA phone.
No longer blocks: 823867
blocking-basecamp: + → ?
Not blocking v1.
blocking-basecamp: ? → -
Comment on attachment 689658 [details] [diff] [review]
use RIL_DEVICE_IDENTITY to get ESN/MEID, v2

Review of attachment 689658 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +5768,5 @@
> +RIL[REQUEST_DEVICE_IDENTITY] = function REQUEST_DEVICE_IDENTITY(length, options) {
> +  if (!options.rilRequestError) {
> +    let result = Buf.readStringList();
> +
> +    this.ESN = result[2];

Could you have some comments about results[0] for IMEI, results[1] for IMEISV and are both ignored?
Attachment #689658 - Flags: review?(vyang) → review+
1). Rebase
2). Address review comment #12
Attachment #689658 - Attachment is obsolete: true
Attachment #696911 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/81d17e61291c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
See Also: → 1110619
You need to log in before you can comment on or make changes to this bug.