816870 - All extensions must require Perl 5.10.1 to pass tests

Status: RESOLVED FIXED

(Bugzilla :: Extensions, defect)

Description

[:glob ✱]

t/002goodperl.t ...... 1/780 
#   Failed test 'extensions/Voting/Extension.pm DOES NOT require Perl 5.10.1 --WARNING'
#   at t/002goodperl.t line 105.

#   Failed test 'extensions/Voting/Config.pm DOES NOT require Perl 5.10.1 --WARNING'
#   at t/002goodperl.t line 105.
# Looks like you failed 2 tests of 780.

Comment 1

[Frédéric Buclin]

The culprit is bug 615627 which now looks into extensions/ when running tests. It was intentional to not require Perl 5.10.1 from extensions. This means that all existing extensions must be updated, as well as templates used by create.pl to generate Config.pm and Extension.pm.

Comment 2

[Matt Selsky [:selsky]]

Attachment: v1

Test 002goodperl.t now passes for all extensions.

t/002goodperl.t .. ok       
All tests successful.
Files=1, Tests=828,  1 wallclock secs ( 0.15 usr  0.01 sys +  0.22 cusr  0.06 csys =  0.44 CPU)
Result: PASS

Comment 3

[Frédéric Buclin]

Comment on attachment 688832 [details] [diff] [review]
v1

> package Bugzilla::Extension::BmpConvert;
>+use 5.10.1;
> use strict;

Please add an empty line between |package Bugzilla::Extension::Foo| and |use 5.10.1| as we do everywhere else.

Comment 4

[Matt Selsky [:selsky]]

Attachment: v2

Blank lines added as requested.

Comment 5

[Frédéric Buclin]

Comment on attachment 692850 [details] [diff] [review]
v2

r=LpSolit, but note that this only fixes t/002goodperl.t. t/011pod.t still complains that these files have no POD.

Comment 6

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified extensions/BmpConvert/Config.pm
modified extensions/BmpConvert/Extension.pm
modified extensions/Example/Config.pm
modified extensions/Example/Extension.pm
modified extensions/Example/lib/Config.pm
modified extensions/Example/lib/Util.pm
modified extensions/Example/lib/WebService.pm
modified extensions/Example/lib/Auth/Login.pm
modified extensions/Example/lib/Auth/Verify.pm
modified extensions/MoreBugUrl/Config.pm
modified extensions/MoreBugUrl/Extension.pm
modified extensions/MoreBugUrl/lib/GetSatisfaction.pm
modified extensions/MoreBugUrl/lib/PHP.pm
modified extensions/MoreBugUrl/lib/RT.pm
modified extensions/MoreBugUrl/lib/ReviewBoard.pm
modified extensions/MoreBugUrl/lib/Rietveld.pm
modified extensions/OldBugMove/Config.pm
modified extensions/OldBugMove/Extension.pm
modified extensions/OldBugMove/lib/Params.pm
modified extensions/Voting/Config.pm
modified extensions/Voting/Extension.pm
modified template/en/default/extensions/config.pm.tmpl
modified template/en/default/extensions/extension.pm.tmpl
modified template/en/default/extensions/util.pm.tmpl
Committed revision 8529.