Closed
Bug 816875
Opened 12 years ago
Closed 12 years ago
Add a "show controls" context menu item on videos with hidden controls
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 20
People
(Reporter: wesj, Assigned: wesj)
Details
Attachments
(1 file, 1 obsolete file)
|
2.67 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Desktop has a "Show controls" context menu item on html video's that have controls hidden like desktop does. That will help ensure there is a scrubber available for sites that don't specify a controls option, i.e.: <video src="">
|
Assignee | |
Comment 1•12 years ago
|
||
This just adds "Show controls". Our touch based controls actually fade out on their own on click (or after a timeout). I think adding "hide controls" will probably be more confusing than helpful ("Hide controls? They're not showing!").
Attachment #690540 -
Flags: review?(mark.finkle)
|
||
Comment 2•12 years ago
|
||
Bad patch?
|
|
Assignee | |
Comment 3•12 years ago
|
||
qref strikes again.
Attachment #690540 -
Attachment is obsolete: true
Attachment #690540 -
Flags: review?(mark.finkle)
Attachment #690623 -
Flags: review?(mark.finkle)
|
|
||
Updated•12 years ago
|
Attachment #690623 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea0207f326a6
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ea0207f326a6
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
|
||
Comment 6•12 years ago
|
||
The preference "Show controls" is added in context Menu : Firefox 20.0a1 (2012-12-17) Device: Galaxy Nexus OS: Android 4.1.1 Video : Example 1 from http://www.w3schools.com/html/html5_video.asp Marking bug as VERIFIED FIXED.
Status: RESOLVED → VERIFIED
|
|
||
Updated•12 years ago
|
Flags: in-moztrap?(ioana.chiorean)
|
|
||
Comment 7•12 years ago
|
||
TC added in MozTrap for Fx Mobile 20 phones,Fx Mobile 20 tablets : https://moztrap.mozilla.org/manage/case/5956/
Flags: in-moztrap?(ioana.chiorean) → in-moztrap+
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•