Closed Bug 816912 Opened 9 years ago Closed 8 years ago

Keyboard Manager to support 3rd-party keyboard app.

Categories

(Firefox OS Graveyard :: Gaia::System, defect, P1)

x86
macOS
defect

Tracking

(blocking-b2g:koi+)

RESOLVED FIXED
blocking-b2g koi+

People

(Reporter: rudyl, Assigned: GaryChen)

References

Details

(Whiteboard: [ucid:SystemPlatform1, FT:System-Platform, koi:p1, Sprint: 2][d-watch])

Attachments

(2 files)

** For V2 - Keyboard **

In Gaia System, we would have a module called KeyboardManager, which will interpret the keyboard app's manifest and keep a list of installed input modules.

We would also need to update the settings app. to enable/disable a specific input module in the list.
Assignee: nobody → ehung
I have a WIP local branch for this issue, but I am trying a better way to launch a keyboard app. I tested to launch and destroy a keyboard app dynamically every time when a input filed is focused/blured, but it took 2-3 seconds to show a keyboard, too slow. I'll try other ways then.
Attachment #734390 - Flags: review?(timdream)
Attachment #734390 - Flags: review?(dflanagan)
(In reply to Evelyn Hung [:evelyn] from comment #3)
> Created attachment 734390 [details]
> point to https://github.com/mozilla-b2g/gaia/pull/9030

To test this patch, please also apply patch in the bug 858383.
Blocks: 858383
Comment on attachment 734390 [details]
point to https://github.com/mozilla-b2g/gaia/pull/9030

Remove r? based on offline discussion.
Attachment #734390 - Flags: review?(timdream)
Attachment #734390 - Flags: review?(dflanagan)
Comment on attachment 734390 [details]
point to https://github.com/mozilla-b2g/gaia/pull/9030

updated and ask review again.
Attachment #734390 - Flags: review?(timdream)
Attachment #734390 - Flags: review?(dflanagan)
Evelyn,

Since this is a v2 feature, I don't think I'm allowed to spend time reviewing it right now: https://groups.google.com/forum/?fromgroups=#!topic/mozilla.dev.gaia/E1xniLLxPoc

Sorry!
Evelyn,

I'm sorry I've let this review sit for so long.  I'm finally getting clear of v1.1 bugs and will be able to start thinking about v1.2.

Is this patch still the one that needs review, or has the code or the design changed since you wrote this?
Assignee: ehung → gchen
Blocks: 891669
Comment on attachment 734390 [details]
point to https://github.com/mozilla-b2g/gaia/pull/9030

Clear review request here because it's out of date. Gary will rebase the code and submit a new review request again. Thanks everyone!
Attachment #734390 - Flags: review?(timdream)
Attachment #734390 - Flags: review?(dflanagan)
Great. FYI we landed a patch that allows you to determine keyboard apps by checking `manifest.role === 'keyboard'`.
blocking-b2g: --- → koi+
Whiteboard: [ucid:SystemPlatform1], [FT: System Platform], [Sprint: 2]
Priority: -- → P1
This is the pull request to add 3rdParty keyboard support.
Please be informed this change would need Gecko m-c to test with.

For this bug, please help review 2742988283856b97c4becb5cac667795bc3b2c7e only, the other 2 commits will be reviewed by other module peers/owners.
Attachment #790121 - Flags: review?(timdream)
Comment on attachment 790121 [details]
pull request: https://github.com/mozilla-b2g/gaia/pull/11528

Good job! Let's discuss this face to face.

The code is mostly correct but before we land this patch I would like to see questions being answered either by more meaningful comments or better naming of the functions.

The code is also too complex and it would be better to be further split into helper classes, accompany with test cases. I don't think it's possible to throughly test this class as-is so it will be a problem further down the road. Let's make sure we do that before more feature is being added onto the code.
Attachment #790121 - Flags: review?(timdream) → review+
Whiteboard: [ucid:SystemPlatform1], [FT: System Platform], [Sprint: 2] → [ucid:SystemPlatform1], [FT:System-Platform], [Sprint: 2]
Whiteboard: [ucid:SystemPlatform1], [FT:System-Platform], [Sprint: 2] → [ucid:SystemPlatform1, FT:System-Platform, koi:p1, Sprint: 2]
Landed to Gaia master
bc8c1c962addd419b48ba12c6d8ddabdf9805391
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
backed out as part of the general backout of the 3rd party keyboard customizations (https://github.com/mozilla-b2g/gaia/commit/42aa1e2ccd22e464bffe6b22ee1182cece5dc2dc) Due to b2g-desktop failures (fail to start) https://travis-ci.org/mozilla-b2g/gaia/builds/10571231#L129.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
Whiteboard: [ucid:SystemPlatform1, FT:System-Platform, koi:p1, Sprint: 2] → [ucid:SystemPlatform1, FT:System-Platform, koi:p1, Sprint: 2][d-watch]
Status: NEW → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Blocks: 936418
You need to log in before you can comment on or make changes to this bug.