816916 - The 'edit saved search' footer link fails for searches where 'foo is not a valid username' has been shown

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Ed Morley [:emorley]]

1) Create a saved search that involves setting a field to an exact username (eg: Custom search -> Status - changed by - [e-mail])
2) Update that user's email address
3) Try to use saved search ("invalid username" + " The name [e-mail] is not a valid username. Either you misspelled it, or the person has not registered for a Bugzilla account.")
4) Use the "edit" link in the "Alternatively, you can forget or edit the saved search 'Intermittent: Resolved today'" text, to try and fix the search.

Expected:
Edit takes you to the usual query.cgi page, with all the fields pre-populated, so you can fix the email address and re-save the search.

Actual:
All fields apart from keywords are not populated on query.cgi, and the keywords field actually contains the query normally expected in the URL, eg in my case:
 
"bug_status=RESOLVED;bug_status=VERIFIED;chfield=bug_status;chfieldfrom=-24h;chfieldto=Now;chfieldvalue=RESOLVED;email1=%40edmorley.co.uk;email2=%40edmorley.co.uk;email3=%40edmorley.co.uk;emailassigned_to3=1;emailcc2=1;emailreporter1=1;emailtype1=notsubstring;emailtype2=notsubstring;emailtype3=notsubstring;field0-0-0=bug_status;keywords=intermittent-failure;keywords_type=allwords;negate0=1;query_format=advanced;type0-0-0=changedby;value0-0-0=<snip>edmorley.co.uk;order=changeddate%2Cbug_status%2Cpriority%2Cassigned_to%2Cbug_id"

Comment 1

[Ed Morley [:emorley]]

(This was using bugzilla.m.o)

Comment 2

[Frédéric Buclin]

This is fixed in 4.2 and newer. 4.0 is restricted to security fixes only and you only get this error when the email address used in your query changed. If the buglist is simply empty (no errors), the "edit search" link is working correctly. Moving this bug to bmo in case they want to fix it. Else you can simply wait for bmo to upgrade to 4.2, which will fix this bug automatically.

Comment 3

[Ed Morley [:emorley]]

Happy to dupe and wait tbh :-)