816979 - java.lang.NoSuchMethodError: android.widget.FrameLayout.setOverScrollMode at org.mozilla.gecko.gfx.LayerView.setOverScrollMode(LayerView.java) on Froyo

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

There's one crash in 20.0a1/20121129: bp-326da4ab-aba1-40ba-997e-379472121130.

java.lang.NoSuchMethodError: android.widget.FrameLayout.setOverScrollMode
	at org.mozilla.gecko.gfx.LayerView.setOverScrollMode(LayerView.java:413)
	at org.mozilla.fennec.WebApp.connectGeckoLayerClient(WebApp.java:235)
	at org.mozilla.gecko.GeckoApp.initialize(GeckoApp.java:1850)
	at org.mozilla.gecko.GeckoApp.onWindowFocusChanged(GeckoApp.java:2126)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.onWindowFocusChanged(PhoneWindow.java:2094)
	at android.view.View.dispatchWindowFocusChanged(View.java:3805)
	at android.view.ViewGroup.dispatchWindowFocusChanged(ViewGroup.java:658)
	at android.view.ViewRoot.handleMessage(ViewRoot.java:1936)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:123)
	at android.app.ActivityThread.main(ActivityThread.java:4668)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:521)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:878)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:636)
	at dalvik.system.NativeStart.main(Native Method)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NoSuchMethodError%3A+android.widget.FrameLayout.setOverScrollMode+at+org.mozilla.gecko.gfx.LayerView.setOverScrollMode%28LayerView.java%29

Comment 1

[Kartikaya Gupta (email:[e-mail])]

wesj, setOverScrollMode is API 9+ only. Not sure what you want to do on API level 8 for this.

Comment 2

[Wesley Johnston (:wesj)]

We should probably just not call the super methods on these. Can post a patch but I don't have a 2.2 device.

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

I think this fixes things but don't have a froyo device to test on. Build is at:

http://people.mozilla.com/~wjohnston/froyoTest.apk

if someone from QA can verify?

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f746d50698c

Comment 5

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/6f746d50698c