817032 - Clean up TinderboxPrint scrape code in MachineResult.js

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

Cleanup whilst waiting to hear the final Talos format from bug 816634, for bug 794901.

Comment 1

[Ed Morley [:emorley]]

Attachment: Part 1: Remove no longer used _getUnitTestResults()

The "machine" names in the mappings (eg "Unit Test") correspond to the test/job pretty names given in Data.js.

"Unit Test" is only matched if we don't otherwise know what a test is (so basically never intentionally); so there's no reason we should special-case it.

"Everythingelse Test" just seems to be an example (or else a now-not-used test pretty-name).

Comment 2

[Ed Morley [:emorley]]

Attachment: Part 2: Remove over-complicated mappings

With the other types removed, we actually only have generic vs talos scrape functions. No need for mappings.

Comment 3

[Ed Morley [:emorley]]

Attachment: Part 3: Stop looking for the slave name

...since it is no longer in the logs (effectively reverts bug 713576)

(As of bug 736085 we now show the slave name in the left hand panel)

Comment 4

[Ed Morley [:emorley]]

Thank you for the reviews :-)

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/d9cf040ade37
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/813aa066f94f
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/2adbb1844cb8

Comment 5

[Jeff Hammel]

And thank you for your cleanup :) I love to see code deleted

Comment 6

[Ed Morley [:emorley]]

In production :-)

Comment 7

[Phil Ringnalda (:philor)]

(In reply to Ed Morley  from comment #1)
> "Everythingelse Test" just seems to be an example (or else a now-not-used
> test pretty-name).

It's been long enough I'm no longer quite sure what wasn't everythingelse, but I think it was two test suites: mochitest (including whichever of browser and browser-chrome existed at the time), and everythingelse, which was xpcshell and reftests and crashtests at least.