81705 - Uncaught Exception in commandglue.js

Status: VERIFIED DUPLICATE of bug 88949

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Oliver Klee]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9+) Gecko/20010517
BuildID: 2001051720

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004003 (NS_ERROR_INVALID_POINTER) [nsIMsgFolder.getMsgDatabase]"  nsresult:
"0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://messenger/content/commandglue.js :: ChangeFolderByDOMNode :: line 118"
 data: no]
Source File: chrome://messenger/content/msgMail3PaneWindow.js
Line: 798

Reproducible: Didn't try

Comment 1

[Oliver Klee]

I've seen this error again while rebuilding my POP folder summaries after I had
deleted all my *.msf files.

Over to Mail database.

Comment 2

[Håkan Waara]

Turns out that nsIMsgFolder::GetMsgDatabase() is not implemented yet.

ChangeFolderByDOMNode() uses it.

No wonder you get a exception there. This may be really bad, if
ChangeFOlderByDOMNode() is broken, that is...

Comment 3

[David :Bienvenu]

NS_IMETHODIMP
nsMsgDBFolder::GetMsgDatabase(nsIMsgWindow *aMsgWindow,
                              nsIMsgDatabase** aMsgDatabase)
{
    GetDatabase(aMsgWindow);
    if (!aMsgDatabase || !mDatabase)
        return NS_ERROR_NULL_POINTER;
    *aMsgDatabase = mDatabase;
    NS_ADDREF(*aMsgDatabase);
    return NS_OK;
}

looks like an implementation to me. It's not a database issue - the db is
returning a legitimate error - it's up to code above it to handle the error.

Comment 4

[Håkan Waara]

NS_IMETHODIMP
nsMsgFolder::GetMsgDatabase(nsIMsgWindow *aMsgWindow,
                            nsIMsgDatabase** aMsgDatabase)
{
    return NS_ERROR_NOT_IMPLEMENTED;
}

This is the code I was thinking of.

Comment 5

[David :Bienvenu]

many methods are not implemented in nsMsgFolder.cpp - they're implemented in the
subclass nsMsgDBFolder. All the folder classes, imap, news, local, inherit from
nsMsgDBFolder so none of them use the empty implementation in nsMsgFolder.cpp - 

Comment 6

[David :Bienvenu]

I'm going to mark this works for me unless someone can reproduce it with a
recent build.

Comment 7

[Oliver Klee]

I'm still getting this bug with 2001063008. Just the line number has changed to 810.

Comment 8

[David :Bienvenu]

Oliver, could you attach steps to recreate this exception? From your comments, I
imagined that I could reproduce this with the following steps, but I could not.

1.Delete .msf files for local folders.
2. Select one of the local folders in the folder pane to rebuild the summary file.

Comment 9

[(not reading, please use [e-mail] instead)]

this is a dup.

I'm working on #88949 now.

see that bug for details.

*** This bug has been marked as a duplicate of 88949 ***

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

verified dup.  I see the same exceptions in Seth's stack in the bug he's working on.