The new bedrock version of /firefox/all/ page should do history management for client-side search

RESOLVED FIXED

Status

P4
enhancement
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: pmac, Assigned: kohei)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1246450] , URL)

Attachments

(1 attachment)

Since the resulting page for both client and server-side search is the same, it'd be nice to add html5 history management to client-side search (add and update the "?q=SEARCH") so that users get basically the same experience from both (save the extra requests and slowness of the non-js version), and could easily copy the permalink for a search to send to people.

I believe this is VERY low priority, but it'd be very nice to have.
Severity: normal → enhancement
Created attachment 8362857 [details] [review]
Pull Request on GitHub

Sent a PR!
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Whiteboard: [kb=1246450]

Comment 2

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/e7e8731e33794a5752dad71ce3320cb8f8252298
Fix Bug 817121 - The new bedrock version of /firefox/all/ page should do history management for client-side search

https://github.com/mozilla/bedrock/commit/140f78663de750fbf67ad97f8a795231230092cf
Merge pull request #1601 from kyoshino/bug-817121-fx-all-history

Fix Bug 817121 - The new bedrock version of /firefox/all/ page should do history management for client-side search

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
fixed on stage
You need to log in before you can comment on or make changes to this bug.