81716 - XPInstall from m0.9 or earlier to m0.9.1 fails (Win)

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Daniel Veditz [:dveditz]]

Using XPInstall to upgrade the browser from mozilla0.9 or earlier to a recent 
build (after 5/17/2001) will fail on Windows as the scripts use install methods 
that didn't exist in the older builds.

The use of WinReg.isKeyWritable(), WinReg.keyExists(), and WinReg.valueExists() 
must only be used after checking either Install.buildID or checking the 
existence of those functions.

Comment 1

[Sean Su]

example test function:
  var is60 = (typeof(buildID) == "undefined");

Comment 2

[Daniel Veditz [:dveditz]]

That would be a sufficient test in the commercial script, but if mozilla.org 
ever gets off the stick and supports update.html then mozilla0.9 people might 
still fail.

 var oldWinReg = (typeof(buildID) == "undefined") || (buildID < 20010518);

alternately, you could simply test for the functions you're about to use when 
you have the winreg object:

  if (typeof(winreg.isKeyWritable) == "function") { then use it }

[Probably should have spelled that function isKeyWriteable. AltaVista shows the 
way you have it wins 300K uses to 50K, but the big-name sites like O'Reilly, 
Maxel, Netscape, etc. seem to prefer that 'e'.

java.sun.com had a fun one: documentation for a Java property "writableAction" 
with the description "Name of the action to set the editor into writeable 
mode." Both ways in the same line of text!]

Comment 3

[Sean Su]

Both of the following dictionary sites were able to locate definitions for
"writable", but not "writeable".  I wonder it "writeable" is Brit?

http://humanities.uchicago.edu/forms_unrest/webster.form.html
http://www.m-w.com/

Comment 4

[Sean Su]

Attachment: patch #1 (ns tree)

Comment 5

[Sean Su]

Attachment: patch #1 (moz tree)

Comment 6

[Sean Su]

Attachment: patch #1 (the real moz tree patch)

Comment 7

[Daniel Veditz [:dveditz]]

r=dveditz, sr=dveditz for commercial tree

Comment 8

[Sean Su]

Attachment: patch #2 (ns tree)

Comment 9

[Sean Su]

Attachment: patch #2 (moz tree)

Comment 10

[Daniel Veditz [:dveditz]]

Thanks for updating the patch, r=/sr= from before stand.

Comment 11

[Sean Su]

patches checked in.

Comment 12

[Grace Bush]

verified code fix- no update.html to test