Closed Bug 817183 Opened 13 years ago Closed 9 years ago

Mozpool attempts to free devices that are in error states

Categories

(Testing Graveyard :: Mozpool, defect)

Product:
Testing Graveyard
Component:
Mozpool
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: mcote, Unassigned)

Details

Steps to reproduce: - Force a device into a failure mode, such as "failed_b2g_downloading" - Request that specific device (not "any") Expected: Request fails, but no device logs are generated since the device should never have been assigned. Actual: Request fails, but the message "ignored event free in state failed_b2g_downloading" appears in the device logs, which implies that the device as at least temporarily assigned (i.e. added to the device_requests table).
Ah, well, the problem is actually obvious: while data.get_free_devices() (used in for "any" requests) only returns devices in the "free" state, data.reserve_device() does not enforce this. data.reserve_device() only enforces (via the schema) the limitation that a device can only be assigned to a single request. It should probably also ensure that the device is in the "free" state.
Mozpool is decommed along with pandas...
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.