Closed Bug 817230 Opened 12 years ago Closed 11 years ago

Slow script dialog pops back up after I saw "& don't ask again"

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-basecamp:-, b2g18+ fixed)

RESOLVED FIXED
B2G C3 (12dec-1jan)
blocking-basecamp -
Tracking Status
b2g18 + fixed

People

(Reporter: cjones, Assigned: ochameau)

References

()

Details

(Keywords: regression, Whiteboard: QARegressExclude)

Attachments

(1 file)

STR
 (1) Run the octane benchmark
 (2) See slow-script dialog pop.  Choose "& don't ask again" and continue.
 (3) See slow-script dialog pop up

This is a broken feature, need to fix or remove.
We have a slow script dialog?!

Alex, is this one of the custom-prompt modals you implemented?
No. But if this has to live in system app, I can take a look at this as I'm now used to add some there.
(In reply to Alexandre Poirot (:ochameau) from comment #2)
> No. But if this has to live in system app, I can take a look at this as I'm
> now used to add some there.

Are you sure? Chris filed this against the browser app so I'm guessing he was using the browser. I didn't implement a slow script dialog so all I can think is that it's using the custom-prompt dialog and for some reason the checkbox isn't working.

I wouldn't expect this to bubble up to the system app, but I could be wrong.
I'd expect that webapps can dispatch slow script dialog popup as well.
If that the case, can't we implement those only in system app ?
(In reply to Alexandre Poirot (:ochameau) from comment #4)
> I'd expect that webapps can dispatch slow script dialog popup as well.
> If that the case, can't we implement those only in system app ?

I don't know where this popup is coming from, but all the other popups (alert, confirm, prompt) are events on the iframe object and have separate implementations in the browser and system. I think permissions dialogs work differently because they use a separate API.
blocking-basecamp: ? → +
Keywords: regression
Priority: -- → P2
Can't we simply set dom.max_script_run_time to 0 and do not show this dialog or is it overkill?

Since applications runs in their own process I would expect this to not be so bad.
Chris, what's your view on comment 6?
Flags: needinfo?(jones.chris.g)
CC'ing Anthony who is currently doing some refactoring work on modal_dialog.js where this dialog is implemented for the browser.
Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.
Target Milestone: --- → B2G C3 (12dec-1jan)
I'm fine with the workaround in comment 6.  The goal is to not have a broken feature.
Flags: needinfo?(jones.chris.g)
Vivien, do you want to make the change to dom.max_script_run_time or shall I talk to Alex and Anthony about trying to get this to work?
Flags: needinfo?(21)
(In reply to Ben Francis [:benfrancis] from comment #11)
> Vivien, do you want to make the change to dom.max_script_run_time or shall I
> talk to Alex and Anthony about trying to get this to work?

I guess Alex can hack it quickly :)
Flags: needinfo?(21)
Assignee: nobody → poirot.alex
Depends on: 820438
I made a little mistake on patch introducing custom modal prompt support.
I attached the checkbox value the wrong returned object...

But that wont fix this issue as there is a platform issue on top of that.
Attachment #690926 - Flags: review?(alive)
Opened platform bug 820443 to fix this gaia bug. It disable the prompt by changing the pref.
Depends on: 820443
Please nominate for approval once reviewed and ready to land.
blocking-basecamp: + → -
tracking-b2g18: --- → +
Sorry for late response, I will pick up this r tomorrow. If this is urgent, please find another reviewer.
Comment on attachment 690926 [details]
Pull request 6953 - fix checkbox support

r=me
Attachment #690926 - Flags: review?(alive) → review+
Landed:
https://github.com/mozilla-b2g/gaia/commit/5d27a85b9147b95e8d222f90bc97e33b45544b15
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: QARegressExclude
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: