The default bug view has changed. See this FAQ.

"this addon could not be installed because it appears to be corrupt" is quite invisible

RESOLVED FIXED in Thunderbird 22.0

Status

Thunderbird
Theme
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Vincent (caméléon), Assigned: Paenglab)

Tracking

Trunk
Thunderbird 22.0
x86_64
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 3 obsolete attachments)

(Reporter)

Description

4 years ago
Created attachment 687441 [details]
funambol-mozilla-sync-client-win32-tb17+dev17.xpi

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20121119183901

Steps to reproduce:

1/ Try to install the add-on attached to this bug (which seems to be a corrupt funambol add-on for TB17 from https://maurus.net/resources/funambol/tb17-dev17/)



Actual results:

Nothing. After looking at it a little bit more, I have seen the error message at the top of the TB windows (attached to the bug report too)


Expected results:

Text color should be in black in order to improve its readability (any other suggestion would be accepted except this white text on a clear background).
(Reporter)

Comment 1

4 years ago
Created attachment 687442 [details]
screenshot of the issue
Is this a theme issue?
Or addon manager?
(Assignee)

Comment 3

4 years ago
Because Firefox uses now the arrow-popups it's a theme issue.

I'll take it.
Component: Untriaged → Theme
(Assignee)

Updated

4 years ago
Assignee: nobody → richard.marti
(Assignee)

Comment 4

4 years ago
Created attachment 706774 [details] [diff] [review]
patch

I removed the special styling for value="addon-install-failed" and let the original styling of notification.css.

I've added inverted close icons to have a better contrast.
Attachment #706774 - Flags: ui-review?(bwinton)
Attachment #706774 - Flags: review?(mconley)
(Assignee)

Comment 5

4 years ago
Created attachment 706775 [details]
patch in action

Screenshot for easier ui-r
(Reporter)

Comment 6

4 years ago
looks great, thanks!
(Assignee)

Comment 7

4 years ago
Created attachment 706813 [details] [diff] [review]
patch

Sorry, forgot one change.
Attachment #706774 - Attachment is obsolete: true
Attachment #706774 - Flags: ui-review?(bwinton)
Attachment #706774 - Flags: review?(mconley)
Attachment #706813 - Flags: ui-review?(bwinton)
Attachment #706813 - Flags: review?(mconley)
Comment on attachment 706813 [details] [diff] [review]
patch


>+++ b/mail/themes/gnomestripe/mail/messenger.css
>@@ -393,20 +393,33 @@
> notification[value="addon-install-blocked"],
>-notification[value="addon-install-failed"],
> notification[value="addon-install-complete"] {
>   background-image: url("chrome://mozapps/skin/extensions/stripes-info-negative.png"),
>                     linear-gradient(rgba(255, 255, 255, 0), rgba(255, 255, 255, 0.5));
>   background-repeat: repeat-x;
> }

The red seems a little bright.  I suggest we add something like:

notification[value="addon-install-failed"] {
  background-image: url("chrome://mozapps/skin/extensions/stripes-error.png"),
                    linear-gradient(rgba(255, 0, 0, 0), rgba(255, 0, 0, 0.5));
  background-repeat: repeat-x;
}

instead.  (Uh, feel free to play around with the colours there…)

Aside from that, ui-r=me!

Thanks,
Blake.
Attachment #706813 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Comment 9

4 years ago
Created attachment 714962 [details] [diff] [review]
patch v2

The red background color was the original from notification.css. This patch lightens the red a little bit.
Attachment #706813 - Attachment is obsolete: true
Attachment #706813 - Flags: review?(mconley)
Attachment #714962 - Flags: ui-review+
Attachment #714962 - Flags: review?(mconley)
(Assignee)

Comment 10

4 years ago
Created attachment 714963 [details]
The actual background color
(Assignee)

Comment 11

4 years ago
Created attachment 719654 [details] [diff] [review]
patch v2 unbitrotted

Patch was bitrotted by HiDPI check-in.
Attachment #714962 - Attachment is obsolete: true
Attachment #714962 - Flags: review?(mconley)
Attachment #719654 - Flags: ui-review+
Attachment #719654 - Flags: review?(mconley)
(Assignee)

Updated

4 years ago
Duplicate of this bug: 847295
Comment on attachment 719654 [details] [diff] [review]
patch v2 unbitrotted

Review of attachment 719654 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks Paenglab!
Attachment #719654 - Flags: review?(mconley) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/20c2fd173fa9
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 22.0
You need to log in before you can comment on or make changes to this bug.