817346 - libvpx Intel C++ and VC9 compilation issue

Status: RESOLVED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Alex Kontos]

Attachment: log

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:16.0) Gecko/20121026 Firefox/16.0
Build ID: 20121026125834

Steps to reproduce:

Compiled Firefox 17/17.0.1 with ICC


Actual results:

Firefox 17 no longer compile libvpx with ICC


Expected results:

Should have compiled fine, since v16 uses the same version of libvpx and doesn't have this error.

Comment 1

[Timothy B. Terriberry (:derf)]

Ted forwarded me the discussion from dev-builds (https://groups.google.com/forum/?hl=en&fromgroups#!topic/mozilla.dev.builds/yoSL-ecFYjY), but my reply never made it out of moderation:

> The initial tranches of WebRTC landed in v17 (behind a pref, but still enabled at
> compile-time), which means the encoder is now being built by default. In prior
> releases we only built the decoder. It looks like the asm offset generation is
> broken in your build. There's currently two ways of doing this (controlled by the
> VPX_NEED_OBJ_INT_EXTRACT flag set in configure.in). I'd recommend changing the
> test for ICC to use the other method, and seeing if this improves things (I'd
> also recommend filing a bug in Core: Video/Audio).

Comment 2

[Timothy B. Terriberry (:derf)]

It may also be helpful to post the contents of your objdir/media/libvpx/asm_enc_offsets.asm

Comment 3

[Bill Gianopoulos [:WG9s]]

I had this issue yesterday using VC9 to build changeset d2fbc67f69f5.  Today's build from changeset 0352a32fde64 built just fine using VC9.

Comment 4

[Bill Gianopoulos [:WG9s]]

This also compiled successfully for my on Friday using changeset abb39d1df815.

So, the regression window was:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=abb39d1df815&tochange=d2fbc67f69f5

The window for the subsequent "fix" was:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d2fbc67f69f5&tochange=0352a32fde64

Nothing really jumps out at me as the cause here.  All of these builds were full source clobbers.

Comment 5

[Alex Kontos]

It appears to have been fixed now (not sure why? Could just be the compilers acting up).