Last Comment Bug 817468 - color of attachment bar with wide view layout different from other layouts
: color of attachment bar with wide view layout different from other layouts
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Toolbars and Tabs (show other bugs)
: 17 Branch
: x86 Windows XP
: -- normal with 1 vote (vote)
: Thunderbird 22.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on: 858010
Blocks:
  Show dependency treegraph
 
Reported: 2012-12-02 18:58 PST by Kennith
Modified: 2013-04-05 02:01 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
XP blue theme, Thunderbird default theme, used wide view (101.60 KB, image/jpeg)
2012-12-02 19:37 PST, Kennith
no flags Details
XP blue theme, Thunderbird default theme, used vertical view (101.94 KB, image/jpeg)
2012-12-02 19:38 PST, Kennith
no flags Details
Showing color of attachement pane under Win 7 (131.81 KB, image/jpeg)
2013-03-14 13:20 PDT, Brian
no flags Details
patch (772 bytes, patch)
2013-03-17 02:15 PDT, Richard Marti (:Paenglab)
mconley: review+
Details | Diff | Splinter Review

Description Kennith 2012-12-02 18:58:16 PST
User Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.95 Safari/537.11

Steps to reproduce:

There are 3 layouts, classic view, wide view, vertical view.
Only wide view reproduced the result.
The color of attachment bar shows different color,
when using different appearances shows different results.


Actual results:

When thunderbird using default theme, windows XP using default silver theme.
color of attachment bar shows grey.

When thunderbird using default theme, windows XP using default blue theme.
color of attachment bar shows blue.

When thunderbird using solid theme called FRESH (solid grey), windows XP using default themes (blue or silver).
color of attachment bar shows black (words are black too).

All of above used wide view, but if all use classic view, all shows normal(grey).
version of 18.0 beta1 also reproduced that.


Expected results:

should be all grey, and not related to the title bar.
Comment 1 Kennith 2012-12-02 19:37:23 PST
Created attachment 687601 [details]
XP blue theme, Thunderbird default theme, used wide view
Comment 2 Kennith 2012-12-02 19:38:32 PST
Created attachment 687602 [details]
XP blue theme, Thunderbird default theme, used vertical view
Comment 3 Brian 2013-03-14 13:19:32 PDT
I can confirm this in Thunderbird 17.0.4 ESR. It is especially annoying under Windows 7, as the attachment pane picks up the transparency of the Aero theme as well.
Comment 4 Brian 2013-03-14 13:20:33 PDT
Created attachment 725069 [details]
Showing color of attachement pane under Win 7
Comment 5 Richard Marti (:Paenglab) 2013-03-17 02:15:46 PDT
Created attachment 725859 [details] [diff] [review]
patch

Setting the appearance a level deeper solves the problem. I saw no negative issues with this patch.
Comment 6 Mike Conley (:mconley) - (Needinfo me!) 2013-03-23 11:53:43 PDT
Comment on attachment 725859 [details] [diff] [review]
patch

Yes please, this is much better.
Comment 7 Mark Banner (:standard8) (afk until 26th July) 2013-03-26 07:43:10 PDT
https://hg.mozilla.org/comm-central/rev/edbd32758cb3

Note You need to log in before you can comment on or make changes to this bug.