817525 - [update] update manager's download prompt's titles should action the checkboxes

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw]]

Bug 809308 introduced the download-prompt-with-checkboxes and Bug 816533 made the checkboxes smaller.

It uses the <label> tag for the checkboxes, which is clearly plain wrong. As a result, the user cannot click/tap the title to enable or disable the checkboxes, which is a more of a problem now that the checkboxes are quite small.

The easiest way would be to have a label englobing a whole line in the download prompt.

Comment 1

[Dylan Oliver [:doliver]]

Etienne, can you comment on this one for triage? 

And can either Etienne or Julien provide a screenshot of the layout after the fix for bug 816533?

Comment 2

[Etienne Segonzac (:etienne)]

If you tap the checkbox you can check or uncheck it.
If you tap the application name on the same line it does not check/uncheck the checkbox.

Not a blocker imho. The fix is rather risky since it involve changing building blocks markup.

Comment 3

[Julien Wajsberg [:julienw]]

Clearly the BB are wrong to use <label> for this, but I could wait for post-v1 to fix this.

However, the settings app manage to make the titles clickable even if it's using the BB for its switches. So I think it may be feasible without touching the BB.

Yet I agree that this is not a blocker.

Comment 4

[BMO Automation]

Firefox OS is not being worked on