817564 - [Calendar UX VD] Remove day label underneath the month grid.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: Should look like this.

Remove the orange date label between the month grid and day events so to have more space when 6 weeks months.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 2

[Kevin Grandon :kgrandon]

Hi Victoria,

While looking at implementing this, we ran into the problem that it no longer displays he date when you switch months. If we move forward with this, we should either clear the list, or select the first day in the month. What do you think?

Comment 3

[Victoria Gerchinhoren [:vicky]]

Hello Kevin,

I am sorry for the delay, must have slip through the craks. 

I don't understand the problem, can you elaborate it?.

The reason for this change is: since the header already indicates the month and year displayed and the day has a very pronounced highlighted state, there's no need to offer the user that information twice.

Comment 4

[Kevin Grandon :kgrandon]

Victoria - The current problem is that you can switch months, and the day can remain on the last month.

E.g., I select Monday April 29th, then swipe right to May. Currently the day does not update, but the month view does. So I'm now viewing the month of May, and showing events and a title for Monday April 29th.

iOS gets around this by selecting the 1st of each month as you change months.

Comment 5

[Victoria Gerchinhoren [:vicky]]

Thanks Kevin, now I see. It makes no sense to keep the previous selection and show all its information after swiping months. So let's do as iOS as it sounds the most logical behaviour.
Thanks!

Comment 6

[James Lal [:lightsofapollo]]

Comment on attachment 728337 [details]
Github pull request pointer

I can rez my patch that does what you described as far as swiping between months goes (I have it from berlin).

Comment 7

[Kevin Grandon :kgrandon]

If you have a patch sitting around already that would be awesome. If not it shouldn't be too hard to implement again. If there is a bug, can you mark this one as a dependent of that?

Comment 8

[James Lal [:lightsofapollo]]

Attached the bug (which you actually reviewed!) to this.

Comment 9

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 10

[James Lal [:lightsofapollo]]

https://github.com/mozilla-b2g/gaia/commit/c85faefe85119afd359ced420c4c05f11497317b