817587 - WebSMS: use MOZ_ASSERT instead of NS_ERROR in SmsManager::Observe()

Status: RESOLVED INVALID

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

See bug 774621 comment #40.

Comment 1

[Mounir Lamouri (:mounir)]

Doesn't that mean that any extension could crash Gecko by sending the appropriate notification without the appropriate object in it? Seems a bit extreme. Also, it might be a bit sensitive security-wise.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Extensions have complete and utter unlimited power to crash Gecko anytime. They can override arbitrary XPCOM class-ids or contract-ids. It's not something we're trying to protect against at all.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Sorry, that came across more abrupt than intended.

We can't protect against extensions crashing gecko given that they can override arbitrary XPCOM contracts/classids.

I also think that we shouldn't worry about people firing internal notifications with wrong data. Notifications cut very deep into gecko and trying to keep them as an "external" API where we can't trust that the caller will do the right thing is simply too hard.

Comment 4

[Mounir Lamouri (:mounir)]

Fair enough.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

There is no longer SmsManager.  Removed in bug 891235.