817589 - move mozAudioChannelType to a separated interface

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

We don't want to change the nsIDOMHTMLMediaElement interface so we are proposing to move any audio channel related thing to a separated interface called nsITMLMediaElement2. This new interface should be enabled only for b2g.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

> We don't want to change the nsIDOMHTMLMediaElement interface

Is this just because you want the new properties to be pref-controlled, or is there something else going on?

Comment 3

[Andrea Marchesini [:baku]]

https://bugzilla.mozilla.org/show_bug.cgi?id=795237#c64
Smaug proposed this approach instead changing the mediaelement interface.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Oh, for beta, sure.  I'm more interested in what happens on trunk going forward; on beta we just do the separate interface.

Specifically, I'm interested in what happens when we stop using XPConnect for media elements and start using WebIDL, at which point the separate-interface thing will be pretty pointless on its own.

Comment 5

[Andrea Marchesini [:baku]]

We can merge these 2 interfaces in future before migrating to webIDL.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This property was added to nsIHTMLMediaElement in aurora, so *removing* it would actually be what would causing a change at this point. So I think we should keep things as they are.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Jonas Sicking (:sicking) from comment #6)
> This property was added to nsIHTMLMediaElement in aurora, so *removing* it
> would actually be what would causing a change at this point. So I think we
> should keep things as they are.
I thought the stuff would land to beta, where we must not change any interfaces.
(If needs-to-land-to-beta is not the case, I have no idea what b2g stuff lands where and when :) )

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Oh, sorry, if it landed already in Aurora, it obviously isn't landing to beta, because it is already there.
I was looking at some patch which was making changes to .idl file and which would be landing to
beta, I guess Bug 805333, but that was about onfoo properties.
My mistake, sorry.