817603 - [Activity Indicator] Wrong spinner graphic after setting up an account

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Attachment: Screen shot showing the use of wrong spinner

The spinner should be the one here:
http://mozilla-b2g.github.com/Gaia-UI-Building-Blocks/#widgets/progress_activity/

Comment 1

[Victoria Gerchinhoren [:vicky]]

Activity indicators are specified by use case, please refer to this link:
https://wiki.mozilla.org/Gaia/Design/BuildingBlocks#Progress_.26_Activity_Indicators

Building blocks for consolidating this are implemented and approval pending:
https://bugzilla.mozilla.org/show_bug.cgi?id=822671

Comment 2

[Steve Chung [:steveck]]

Hi Victoria, This issue fixed in : https://github.com/mozilla-b2g/gaia/commit/c1833be73a8b18816d272ad88b9bb6b1bc961741 If you think current layout does not match the requirement, please reopen it. Thanks.

Comment 3

[John Ford [:jhford] CET/CEST Berlin Time]

This commit does not apply cleanly to v1-train, v1.0.0.  If this patch depends on another bug, please comment here and I will retry when that bug is approved to land on all branches that this bug needs to land on.  If the merge conflict needs to be resolved by hand, the following commands could be a useful starting point:

cd gaia
git checkout v1-train
git cherry-pick -x c1833be73a8b18816d272ad88b9bb6b1bc961741
<resolve merge conflict>
git checkout v1.0.0
git cherry-pick -x $(git log --pretty=%H -n1 v1-train)

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

It looks like this bug is being fixed as part of bug 808576, let's use that bug to track this fix.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Removing the tef+ in that case since we are tracking the fix in bug 808576.