Closed Bug 817656 Opened 12 years ago Closed 11 years ago

Speed up slow ratings tests

Categories

(Marketplace Graveyard :: Code Quality, defect, P4)

Product:
Marketplace Graveyard
Component:
Code Quality
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
2013-01-10

People

(Reporter: andy+bugzilla, Assigned: ashort)

References

Details

(Keywords: perf) 

The slowest test in terms of setup time (fixtures, everything in setUp) is:

zamboni.mkt.ratings.tests.test_views.TestCreate

And of the 20 slowest tests, a couple of the tests in that class are the slowest, eg:

zamboni.mkt.ratings.tests.test_views.TestCreate.test_body_has_url
zamboni.mkt.ratings.tests.test_views.TestListing.test_detail_local_reviews_only

etc.. clocking in at around 3.5 seconds a test.
Assignee: nobody → ashort
Priority: -- → P4
Target Milestone: --- → 2013-01-10
Got around a 30% speedup. Most of the time is spent in the ORM, of course. 

https://github.com/mozilla/zamboni/commit/ec681e2f867dcc6c88117c6199167779eea73968
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
It still shows up as the slowest test in the site however.

http://cl.ly/image/1M3w152X3p3G
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
making our tests faster is going to require an overhaul of more than a few things.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.