Speed up slow ratings tests

RESOLVED WONTFIX

Status

Marketplace
Code Quality
P4
normal
RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: andym, Assigned: ashort)

Tracking

({perf})

2013-01-10
x86
Mac OS X
Points:
---

Details

(Reporter)

Description

4 years ago
The slowest test in terms of setup time (fixtures, everything in setUp) is:

zamboni.mkt.ratings.tests.test_views.TestCreate

And of the 20 slowest tests, a couple of the tests in that class are the slowest, eg:

zamboni.mkt.ratings.tests.test_views.TestCreate.test_body_has_url
zamboni.mkt.ratings.tests.test_views.TestListing.test_detail_local_reviews_only

etc.. clocking in at around 3.5 seconds a test.
Assignee: nobody → ashort
Priority: -- → P4
Target Milestone: --- → 2013-01-10
(Assignee)

Comment 1

4 years ago
Got around a 30% speedup. Most of the time is spent in the ORM, of course. 

https://github.com/mozilla/zamboni/commit/ec681e2f867dcc6c88117c6199167779eea73968
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

4 years ago
It still shows up as the slowest test in the site however.

http://cl.ly/image/1M3w152X3p3G
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 3

4 years ago
making our tests faster is going to require an overhaul of more than a few things.
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → WONTFIX

Updated

3 years ago
Blocks: 1075278
You need to log in before you can comment on or make changes to this bug.