817683 - Gift suggestions don't render on whatfuckinggiftshouldibuy.com

Status: NEW

(Core :: Layout, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

(sorry for the language)

Firefox never renders the dynamically generated gift suggestions, whereas chrome does.

I'm assuming this is an invalidation bug, so CC'ing Matt and Chris.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is this a regression?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Doesn't seem to be.

The data XML file this page is using is not well-formed: http://whatfuckinggiftshouldibuy.com/wfgsibGiftList.xml

In that situation we drop the data altogether if it's in XHR while Chrome might be exposing data up to the place where the well-formedness error occurs...

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Is that the "right" thing to do in this case?

Comment 4

[Boris Zbarsky [:bzbarsky]]

The spec says:

  Otherwise, let document be a document that represents the result of parsing the
  response entity body following the rules set forth in the XML specifications. If that
  fails (unsupported character encoding, namespace well-formedness error, etc.), return
  null and terminate these steps. 

Neither we nor Chrome do that; we return a document with a parseerror root; they return something I can't quite figure out.

We should try to sort out whether this is in fact the problem, before we worry about it more...  The XML I get from that URL always seems to be the same (even if I pass the GET params the page is using), and doesn't match what the page is showing even in Chrome (the well-formedness error , so maybe it's a red herring?  On the other hand, if I hack the XML to include encoding="ISO-8859-1" then I still get a parse error due to mismatched tags but much later; maybe the site sends that encoding somehow (though wget isn't showing that in the headers...).