817842 - Modify client to handle clock skew for If-Modified-Since header

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Product Announcements, defect)

Description

[JR Conlin [:jrconlin,:jconlin]]

Some client may have an incorrectly set clock. This can cause duplication of campaign messages or some campaign messages not being seen by the client.

The requested work-around is to have the client echo the "Date" header contained in the server response back as the "If-Modified-Since" header.

Comment 1

[Richard Newman [:rnewman]]

https://github.com/mozilla-services/android-sync/pull/274

Comment 2

[Richard Newman [:rnewman]]

Attachment: Patch against inbound. v1

See also pull req, 'cept this is rebased onto master to avoid landing Sync auth changes.

Comment 3

[Tracy Walker [:tracy]]

This looks good on rnewmans test build.  I set the device clock forward several hours. I still get the announcement.

Comment 4

[Richard Newman [:rnewman]]

Attachment: Reviewed patch. v2

This has been reviewed, and incorporates review comments. nalexander, please set flag.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  -- Feature not yet landed. Server/client integration testing is finishing up now.

User impact if declined: 
  -- Users with a clock that's behind will see some announcements twice. Users with a clock that's fast will not see some announcements.

Testing completed (on m-c, etc.): 
  -- Tracy has verified a build. Just landed on inbound.

Risk to taking this patch (and alternatives if risky): 
  -- Nil. Code is currently preffed off; these are changes revealed by testing that we want to make before preffing on.

String or UUID changes made by this patch: 
  -- None.

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dafb0368260c

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 688359 [details] [diff] [review]
Reviewed patch. v2

Review of attachment 688359 [details] [diff] [review]:
-----------------------------------------------------------------

reviewed in github, and review comments addressed.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dafb0368260c

Comment 8

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fa18bde3e25a
https://hg.mozilla.org/releases/mozilla-beta/rev/63bb353f6278