Closed Bug 817842 Opened 8 years ago Closed 8 years ago
Modify client to handle clock skew for If-Modified-Since header
Some client may have an incorrectly set clock. This can cause duplication of campaign messages or some campaign messages not being seen by the client. The requested work-around is to have the client echo the "Date" header contained in the server response back as the "If-Modified-Since" header.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Component: Server: Product Announcements Campaign Manager → Android: Product Announcements
OS: Windows 7 → Android
Hardware: x86_64 → ARM
See also pull req, 'cept this is rebased onto master to avoid landing Sync auth changes.
This looks good on rnewmans test build. I set the device clock forward several hours. I still get the announcement.
QA Contact: twalker
This has been reviewed, and incorporates review comments. nalexander, please set flag. [Approval Request Comment] Bug caused by (feature/regressing bug #): -- Feature not yet landed. Server/client integration testing is finishing up now. User impact if declined: -- Users with a clock that's behind will see some announcements twice. Users with a clock that's fast will not see some announcements. Testing completed (on m-c, etc.): -- Tracy has verified a build. Just landed on inbound. Risk to taking this patch (and alternatives if risky): -- Nil. Code is currently preffed off; these are changes revealed by testing that we want to make before preffing on. String or UUID changes made by this patch: -- None.
Target Milestone: --- → mozilla20
Comment on attachment 688359 [details] [diff] [review] Reviewed patch. v2 Review of attachment 688359 [details] [diff] [review]: ----------------------------------------------------------------- reviewed in github, and review comments addressed.
Attachment #688359 - Flags: review?(nalexander) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: Android: Product Announcements → Product Announcements
Product: Mozilla Services → Android Background Services
You need to log in before you can comment on or make changes to this bug.