81786 - Regression: default charset list stopped working

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P1)

Description

[Aleksey Nogin]

No matter what I do, the "Folder character config" always stays on "ISO-8859-1".
Sometimes the dropdown menu there would have other choices (although not the
KOI8-R I want) such as "User Defined" or "UTF-7" but clicking on them does not
do anything - it would still say "ISO-8859-1". Because of this, I can not get
Mozilla to show the subjects of non-mime messages using the KOI8-R font.

I am currently running Build 20010518 on RedHat Linux 7.2. This used to work
fine in 0.9.

My preferences look as follows:

user_pref("intl.accept_charsets", "koi8-r;q=1.0;iso-8859-1;q=0.1,utf-8;q=0.1");
user_pref("intl.accept_languages", "ru, en");
user_pref("intl.charset.detector", "ruprob");
user_pref("intl.charsetmenu.browser.cache", "KOI8-R, ISO-8859-15, UTF-8,
ISO-8859-5, windows-1252");
user_pref("intl.charsetmenu.browser.static", "ISO-8859-1, KOI8-R, windows-1251,
IBM866, UTF-7, UTF-8");
user_pref("intl.charsetmenu.mailview.cache", "KOI8-R, us-ascii");
user_pref("intl.font_charset", "UTF-8");
user_pref("intl.font_spec_list", "...");

Comment 1

[Alexey Chernyak]

seeing this on Win2K 2001051820 as well.

Comment 2

[ji]

Same problem with global default.
Nominating for nsbeta1. 
It makes charset override totally unusable.

Comment 3

[ji]

Same problem with the default charset list on  Browser's Edit | Preference | 
Navigator | Languages window. Changed the component to browser.

Comment 4

[ji]

Modified the summary accordingly.

Comment 5

[ji]

This problem starts to happen from 2001-05-17-21-mtrunk build. The last good 
build is 2001-05-17-08-mtrunk.

Comment 6

[nhottanscp]

Check in from 2001-05-17-8 to 2001-05-17-21,

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=05%2F17%2F2001+08%3A00%3A00&maxdate=05%2F17%2F2001+21%3A00%3A00&cvsroot=%2Fcvsroot

Reassign to jbetak.

Comment 7

[Yuying Long]

Same problem on [Composer] View | Character Coding | <default charset missing>

Comment 8

[[e-mail] (away - not reading bugmail)]

accepting, researching the regression

Comment 9

[[e-mail] (away - not reading bugmail)]

I believe this might have been caused by Roy's checkin:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/intl/uconv/src&command=DIFF_LINKS&root=/cvsroot&file=nsCharsetMenu.cpp&rev1=1.54&rev2=1.55

I'm currently trying to verify this hypothesis... CCing Roy.

Comment 10

[[e-mail] (away - not reading bugmail)]

OK, so it really seem like it was the change to nsCharsetMenu.cpp, I'm working 
with Roy on the fix - ETA is this afternoon.

Comment 11

[Jaime Rodriguez, Jr.]

Jbetak - Pls mark as M0.9.1. Plusing this one.

Comment 12

[[e-mail] (away - not reading bugmail)]

marking 0.9.1 per Jaime's comment

Comment 13

[[e-mail] (away - not reading bugmail)]

*** Bug 81839 has been marked as a duplicate of this bug. ***

Comment 14

[[e-mail] (away - not reading bugmail)]

reassigning to Roy...

Comment 15

[Roy Yokoyama]

I will post a fix in a minute.

Comment 16

[Roy Yokoyama]

Attachment: cloning decoder/encode lists

Comment 17

[Roy Yokoyama]

brief description:  
It was removing items from nsCOMPtr<nsISupportsArray> mDecoderList for
each application (such as Browser, Composer, etc)  I made so that
the each app::Init() has its own Clone of decoder list.

ftang: can you /r = ? 

Comment 18

[Frank Tang]

r=ftang

Comment 19

[Roy Yokoyama]

brendan: can you /sr=?

Comment 20

[Johnny Stenback (:jst)]

sr=scc

Comment 21

[marina]

*** Bug 81815 has been marked as a duplicate of this bug. ***

Comment 22

[Roy Yokoyama]

checked-in

Comment 23

[nhottanscp]

*** Bug 82263 has been marked as a duplicate of this bug. ***

Comment 24

[Brendan Eich [:brendan]]

Sorry, my laptop (my lifeline) was dying (bad SIMM) and I didn't get to sr= this
in time -- thanks to others for covering.

/be

Comment 25

[ji]

Verified with 05/23 trunk builds on all the three platforms. 
It's fixed. The default charset list now contains 67 items as before.