Closed Bug 817951 Opened 12 years ago Closed 12 years ago

The elapse time of idle timer needs to be calculate monotonically

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86_64
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-basecamp:+)

Status:
VERIFIED FIXED
Milestone:
B2G C2 (20nov-10dec)
Project Flags:
blocking-basecamp +

People

(Reporter: shelly, Assigned: timdream)

References

Details

Attachments

(1 file)

Github: https://github.com/mozilla-b2g/gaia/pull/6802
11 bytes, text/plain
vingtetun
: review+
shelly
: feedback+
Details 
In gaia/shared/js/idletimer.js, observe that we are using Date.now() to calculate the elapse time of idle timer. This is causing issue of bug 803039.
Blocks: 803039
blocking-basecamp: --- → ?
Assignee: nobody → timdream+bugs
blocking-basecamp: ? → +
Priority: -- → P1
Target Milestone: --- → B2G C2 (20nov-10dec)
Shelly got a WIP patch.
Assignee: timdream+bugs → slin
According to Shelly, my WIP patch works -- let me wrap it up for review.
Assignee: slin → timdream+bugs
STR:

1. Go to setting and manually change the system time to a future time
2. Press "OK" on the time picker and don't touch the screen and button again

Expected:

1. nothing

Actual:

1. The screen idle-dim-timeout will be triggered.


This patch fix this.
Attachment #688186 - Flags: review?(21)
Attachment #688186 - Flags: feedback?(slin)
Attachment #688186 - Flags: feedback?(slin) → feedback+
Fix verified in Unagi build 20130102070202.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: