Closed Bug 817952 Opened 12 years ago Closed 11 years ago

B2G STKUI: Add support for STK_CMD_PROVIDE_LOCAL_INFO

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:-)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g -

People

(Reporter: allstars.chh, Assigned: frsela)

References

Details

(Whiteboard: [u=commsapps-user c=stk p=0], [Sprint2])

Attachments

(1 file)

Implemented STK_CMD_PROVIDE_LOCAL_INFO command
363 bytes, text/html
timdream
: review+
allstars.chh
: feedback+
Details 
From Bug 804671, we implemented platform side of 'Provide local information', so this bug is required to handle that proactive command in gaia part.
Depends on: 804671
No longer depends on: 804761
blocking-b2g: --- → shira+
Whiteboard: [triaged:1/18]
Whiteboard: [triaged:1/18] → [mno11][triaged:1/18]
blocking-b2g: shira+ → ---
Whiteboard: [mno11][triaged:1/18]
blocking-b2g: --- → koi?
Tested with this commands and generated responses:

Location INFO:

I/GeckoDump(  829): [system] sendStkResponse to command: {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":{"localInfoType":0}}

I/GeckoDump(  829): [system] sendStkResponse -- # response = {"localInfo":{"locationInfo":{"mcc":"214","mnc":"07","gsmLocationAreaCode":2868,"gsmCellId":178793849}},"resultCode":0}

IMEI:

I/GeckoDump(  829): [system] sendStkResponse to command: {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":{"localInfoType":1}}

I/GeckoDump(  829): [system] sendStkResponse -- # response = {"localInfo":{"imei":"864899012583340"},"resultCode":0}

DATE/TIME:

I/GeckoDump(  829): [system] sendStkResponse to command: {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":{"localInfoType":3}}

I/GeckoDump(  829): [system] sendStkResponse -- # response = {"localInfo":{"date":"2013-08-02T09:08:25.256Z"},"resultCode":0}

LANGUAGE:

I/GeckoDump(  829): [system] sendStkResponse to command: {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":{"localInfoType":4}}

I/GeckoDump(  829): [system] sendStkResponse -- # response = {"localInfo":{"language":"en"},"resultCode":0}

--

@sync-1@bugzilla.tld Can you check if this patch fixes 896346?
Assignee: nobody → frsela
Status: NEW → ASSIGNED
Attachment #784883 - Flags: feedback?(allstars.chh)
Flags: needinfo?(sync-1)
Whiteboard: [u=commsapps-user c=stk p=0][Sprint2]
(In reply to Fernando R. Sela [:frsela] from comment #1)
{"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> {"localInfoType":0}}
> 
> I/GeckoDump(  829): [system] sendStkResponse -- # response =
> {"localInfo":{"locationInfo":{"mcc":"214","mnc":"07","gsmLocationAreaCode":
> 2868,"gsmCellId":178793849}},"resultCode":0}

I found in the IDL the mcc and mnc are still type of 'unsigned short', they should be DOMString now.

But I think your code would still work.

I'll file a bug to handle the 'unsigned short' of mcc/mnc.
Attachment #784883 - Flags: feedback?(allstars.chh) → feedback+
(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #2)
> (In reply to Fernando R. Sela [:frsela] from comment #1)
> {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> > {"localInfoType":0}}
> > 
> > I/GeckoDump(  829): [system] sendStkResponse -- # response =
> > {"localInfo":{"locationInfo":{"mcc":"214","mnc":"07","gsmLocationAreaCode":
> > 2868,"gsmCellId":178793849}},"resultCode":0}
> 
> I found in the IDL the mcc and mnc are still type of 'unsigned short', they
> should be DOMString now.
> 
> But I think your code would still work.
> 
> I'll file a bug to handle the 'unsigned short' of mcc/mnc.

Cool, thanks Yoshi
Attachment #784883 - Flags: review?(timdream)
Whiteboard: [u=commsapps-user c=stk p=0][Sprint2] → [u=commsapps-user c=stk p=0], [Sprint2]
Attachment #784883 - Flags: review?(timdream) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/32c4349d1194e5588f093c6cd3896049c8c2899d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #1)
> Created attachment 784883 [details]
> Implemented STK_CMD_PROVIDE_LOCAL_INFO command
> 
> Tested with this commands and generated responses:
> 
> Location INFO:
> 
> I/GeckoDump(  829): [system] sendStkResponse to command:
> {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> {"localInfoType":0}}
> 
> I/GeckoDump(  829): [system] sendStkResponse -- # response =
> {"localInfo":{"locationInfo":{"mcc":"214","mnc":"07","gsmLocationAreaCode":
> 2868,"gsmCellId":178793849}},"resultCode":0}
> 
> IMEI:
> 
> I/GeckoDump(  829): [system] sendStkResponse to command:
> {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> {"localInfoType":1}}
> 
> I/GeckoDump(  829): [system] sendStkResponse -- # response =
> {"localInfo":{"imei":"864899012583340"},"resultCode":0}
> 
> DATE/TIME:
> 
> I/GeckoDump(  829): [system] sendStkResponse to command:
> {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> {"localInfoType":3}}
> 
> I/GeckoDump(  829): [system] sendStkResponse -- # response =
> {"localInfo":{"date":"2013-08-02T09:08:25.256Z"},"resultCode":0}
> 
> LANGUAGE:
> 
> I/GeckoDump(  829): [system] sendStkResponse to command:
> {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> {"localInfoType":4}}
> 
> I/GeckoDump(  829): [system] sendStkResponse -- # response =
> {"localInfo":{"language":"en"},"resultCode":0}
> 
> --
> 
> @sync-1@bugzilla.tld Can you check if this patch fixes 896346?

there is some error in modem; we will check this patch in later version;
Flags: needinfo?(sync-1)
(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #1)
> Created attachment 784883 [details]
> Implemented STK_CMD_PROVIDE_LOCAL_INFO command
> 
> Tested with this commands and generated responses:
> 
> Location INFO:
> 
> I/GeckoDump(  829): [system] sendStkResponse to command:
> {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> {"localInfoType":0}}
> 
> I/GeckoDump(  829): [system] sendStkResponse -- # response =
> {"localInfo":{"locationInfo":{"mcc":"214","mnc":"07","gsmLocationAreaCode":
> 2868,"gsmCellId":178793849}},"resultCode":0}
> 
> IMEI:
> 
> I/GeckoDump(  829): [system] sendStkResponse to command:
> {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> {"localInfoType":1}}
> 
> I/GeckoDump(  829): [system] sendStkResponse -- # response =
> {"localInfo":{"imei":"864899012583340"},"resultCode":0}
> 
> DATE/TIME:
> 
> I/GeckoDump(  829): [system] sendStkResponse to command:
> {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> {"localInfoType":3}}
> 
> I/GeckoDump(  829): [system] sendStkResponse -- # response =
> {"localInfo":{"date":"2013-08-02T09:08:25.256Z"},"resultCode":0}
> 
> LANGUAGE:
> 
> I/GeckoDump(  829): [system] sendStkResponse to command:
> {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> {"localInfoType":4}}
> 
> I/GeckoDump(  829): [system] sendStkResponse -- # response =
> {"localInfo":{"language":"en"},"resultCode":0}
> 
> --
> 
> @sync-1@bugzilla.tld Can you check if this patch fixes 896346?

(In reply to buri.blff from comment #7)
> (In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from
> comment #1)
> > Created attachment 784883 [details]
> > Implemented STK_CMD_PROVIDE_LOCAL_INFO command
> > 
> > Tested with this commands and generated responses:
> > 
> > Location INFO:
> > 
> > I/GeckoDump(  829): [system] sendStkResponse to command:
> > {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> > {"localInfoType":0}}
> > 
> > I/GeckoDump(  829): [system] sendStkResponse -- # response =
> > {"localInfo":{"locationInfo":{"mcc":"214","mnc":"07","gsmLocationAreaCode":
> > 2868,"gsmCellId":178793849}},"resultCode":0}
> > 
> > IMEI:
> > 
> > I/GeckoDump(  829): [system] sendStkResponse to command:
> > {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> > {"localInfoType":1}}
> > 
> > I/GeckoDump(  829): [system] sendStkResponse -- # response =
> > {"localInfo":{"imei":"864899012583340"},"resultCode":0}
> > 
> > DATE/TIME:
> > 
> > I/GeckoDump(  829): [system] sendStkResponse to command:
> > {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> > {"localInfoType":3}}
> > 
> > I/GeckoDump(  829): [system] sendStkResponse -- # response =
> > {"localInfo":{"date":"2013-08-02T09:08:25.256Z"},"resultCode":0}
> > 
> > LANGUAGE:
> > 
> > I/GeckoDump(  829): [system] sendStkResponse to command:
> > {"commandNumber":1,"typeOfCommand":38,"commandQualifier":0,"options":
> > {"localInfoType":4}}
> > 
> > I/GeckoDump(  829): [system] sendStkResponse -- # response =
> > {"localInfo":{"language":"en"},"resultCode":0}
> > 
> > --
> > 
> > @sync-1@bugzilla.tld Can you check if this patch fixes 896346?
> 
> there is some error in modem; we will check this patch in later version;

we test the patch:
we find the 
[system] sendStkResponse -- # response =
{"localInfo":{"date":"2013-08-02T09:08:25.256Z"},"resultCode":0} has been given to vendor, but the vendor dosen't give the tr to rill->modem, so this case faild;
Dose the mozilla engineer communicate with qcom engineer when give the patch??
(In reply to buri.blff from comment #8)
> 
> we test the patch:
> we find the 
> [system] sendStkResponse -- # response =
> {"localInfo":{"date":"2013-08-02T09:08:25.256Z"},"resultCode":0} has been
> given to vendor, but the vendor dosen't give the tr to rill->modem, so this
> case faild;

Asking Yoshi as STK platform maintainer
Flags: needinfo?(allstars.chh)
Log, please.
Flags: needinfo?(allstars.chh)
Also I'd suggest you create a new bug for this.
(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #12)
> Also I'd suggest you create a new bug for this.

Agree, this is resolved and fixed.

New bug: 908116
I don't think we block on STK bugs.
blocking-b2g: koi? → -
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: