Closed Bug 817955 Opened 11 years ago Closed 11 years ago

Identity modules are installed both under modules/ and modules/identity

Categories

(Core Graveyard :: Identity, defect)

defect
Not set
normal

Tracking

(firefox18 fixed, firefox19 fixed, firefox20 fixed)

RESOLVED FIXED
mozilla20
Tracking Status
firefox18 --- fixed
firefox19 --- fixed
firefox20 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Most of the imports are from modules/identity, so I guess this is where they all should be.
Assignee: nobody → mh+mozilla
Blocks: 762993
Comment on attachment 688142 [details] [diff] [review]
Only install identity modules in modules/identity

Review of attachment 688142 [details] [diff] [review]:
-----------------------------------------------------------------

looks good to me, checking with Jed to make sure there isn't something I'm missing.
Attachment #688142 - Flags: review?(jparsons)
Attachment #688142 - Flags: review?(benadida)
Attachment #688142 - Flags: review+
Comment on attachment 688142 [details] [diff] [review]
Only install identity modules in modules/identity

Looks good.  Thanks for tidying this up, Mike.
Attachment #688142 - Flags: review?(jparsons) → review+
https://hg.mozilla.org/mozilla-central/rev/c8f9d0908bc8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment on attachment 688142 [details] [diff] [review]
Only install identity modules in modules/identity

[Approval Request Comment]
Bug caused by (feature/regressing bug #): feature; cleanup
User impact if declined: none
Testing completed (on m-c, etc.): manual
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none
Attachment #688142 - Flags: approval-mozilla-beta?
Comment on attachment 688142 [details] [diff] [review]
Only install identity modules in modules/identity

This needs to land on Aurora as well.
Attachment #688142 - Flags: approval-mozilla-beta?
Attachment #688142 - Flags: approval-mozilla-beta+
Attachment #688142 - Flags: approval-mozilla-aurora+
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.