Closed Bug 817960 Opened 7 years ago Closed 7 years ago

cannot build AssemblerBufferWithConstantPool.h by clang 3.1 in NDK r8c

Categories

(Core :: JavaScript Engine, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

getPoolSpace has return-type, but don't return value.  So clang detects error.

But, no one uses getPoolSpace when landing bug 696825...
Attached patch fixSplinter Review
It this still needed?
Assignee: general → m_kato
Attachment #688677 - Flags: review?(mrosenberg)
Comment on attachment 688677 [details] [diff] [review]
fix

Review of attachment 688677 [details] [diff] [review]:
-----------------------------------------------------------------

I wrote a lot of code because I thought it would be useful.  I probably should have put some more thought into it...
Attachment #688677 - Flags: review?(mrosenberg) → review+
https://hg.mozilla.org/mozilla-central/rev/6db9b2f36039
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.