Closed
Bug 817960
Opened 12 years ago
Closed 12 years ago
cannot build AssemblerBufferWithConstantPool.h by clang 3.1 in NDK r8c
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
|
1.77 KB,
patch
|
mjrosenb
:
review+
|
Details | Diff | Splinter Review |
getPoolSpace has return-type, but don't return value. So clang detects error. But, no one uses getPoolSpace when landing bug 696825...
|
Assignee | |
Comment 1•12 years ago
|
||
It this still needed?
Assignee: general → m_kato
Attachment #688677 -
Flags: review?(mrosenberg)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 688677 [details] [diff] [review] fix Review of attachment 688677 [details] [diff] [review]: ----------------------------------------------------------------- I wrote a lot of code because I thought it would be useful. I probably should have put some more thought into it...
Attachment #688677 -
Flags: review?(mrosenberg) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6db9b2f36039
Target Milestone: --- → mozilla20
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6db9b2f36039
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•