817983 - [Wifi] DHCP failed to run, wifi status bar is always in connecting.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Vincent Chang[:vchang][changyihsin]]

Attachment: logcat when dhcp failed to run

I found this bug when I am trying to reproduce Bug 809663, not sure the detail STR.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed patch

I think the problem is that we only call reassociate when DHCP fails to connect, and if we're already connected, reassociate triggers a reauth but doesn't disconnect and reconnect, meaning that we'll simply ignore the CONNECTED (reauth) event.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 688538 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
User impact if declined: Wifi can get stuck in a partially connected state but without an IP address or the ability to actually connect to the internet.
Risk to taking this patch (and alternatives if risky): Low risk, should be a rare codepath.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95b05aca04a3

Comment 4

[Alex Keybl [:akeybl]]

Comment on attachment 688538 [details] [diff] [review]
Proposed patch

Low risk fix specific to B2G - the web's the platform, so let's make sure our users can connect to it :).

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/95b05aca04a3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1ea7bf170749
https://hg.mozilla.org/releases/mozilla-beta/rev/ff4c3c143231