Closed Bug 817983 Opened 8 years ago Closed 8 years ago

[Wifi] DHCP failed to run, wifi status bar is always in connecting.

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox18 fixed, firefox19 fixed, firefox20 fixed)

RESOLVED FIXED
B2G C2 (20nov-10dec)
Tracking Status
firefox18 --- fixed
firefox19 --- fixed
firefox20 --- fixed

People

(Reporter: vchang, Assigned: mrbkap)

Details

Attachments

(2 files)

I found this bug when I am trying to reproduce Bug 809663, not sure the detail STR.
Attached patch Proposed patchSplinter Review
I think the problem is that we only call reassociate when DHCP fails to connect, and if we're already connected, reassociate triggers a reauth but doesn't disconnect and reconnect, meaning that we'll simply ignore the CONNECTED (reauth) event.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #688538 - Flags: review?(vchang)
Attachment #688538 - Flags: review?(vchang) → review+
Comment on attachment 688538 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
User impact if declined: Wifi can get stuck in a partially connected state but without an IP address or the ability to actually connect to the internet.
Risk to taking this patch (and alternatives if risky): Low risk, should be a rare codepath.
Attachment #688538 - Flags: approval-mozilla-beta?
Attachment #688538 - Flags: approval-mozilla-aurora?
Comment on attachment 688538 [details] [diff] [review]
Proposed patch

Low risk fix specific to B2G - the web's the platform, so let's make sure our users can connect to it :).
Attachment #688538 - Flags: approval-mozilla-beta?
Attachment #688538 - Flags: approval-mozilla-beta+
Attachment #688538 - Flags: approval-mozilla-aurora?
Attachment #688538 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/95b05aca04a3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.