818015 - Order of variables for date elements is wrong for locales in Homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P3)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: screenshot of the bug

On the Home Screen, the date is badly displayed in French, the words are translated but the format uses English syntax.

The lockscreen does not have this bug.

Lockscreen: mardi 4 décembre
Homescreen: mardi, décembre 4

I see that with a Firefox OS Desktop client based on the mozilla-beta repo + the gaia repo

I have a small patch that fixes that locally. Will do a pull request referencing this bug

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6804

Pointer to Github pull-request

Comment 2

[Fabien Cazenave [:kaze]]

Comment on attachment 689185 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6804

Unless I miss something, the fix you propose would not work in English.

The real fix would be to understand why the _('longDateFormat') string is not properly returned. This looks like an initialization issue (e.g. init before l10n is ready).

Comment 3

[Fabien Cazenave [:kaze]]

However, this bug remains valid and should be fixed ASAP. Nominating for blocking-basecamp.

Comment 4

[Fabien Cazenave [:kaze]]

Blocks bug 811242 which is bb+.

Comment 5

[Fabien Cazenave [:kaze]]

OK, turns out the problem is a pure l10n one: the code works fine but the homescreen/locales/*.properties files are not up-to-date. As _('longDateFormat') is not defined for French (nor for any other supported locale in this repository…), the English format is used instead.

Pike and/or Staś, would you please update the Gaia repository with the *.properties files for [ar], [fr] and [zh-TW] from your repo?

Comment 6

[Axel Hecht [:Pike]]

stas said that he's doing another migration before going on PTO

Comment 7

[Staś Małolepszy :stas]

I opened https://github.com/mozilla-b2g/gaia/pull/6863.  I'll probably open a new bug, too.

Comment 8

[Alex Keybl [:akeybl]]

From our read, this doesn't impact any 1.0 shipping locales. We can revisit for a future version.

Comment 9

[Fabien Cazenave [:kaze]]

fixed by bug 818999