while staging some changes to sut_tools, I found an error: remotereftest.py", line 445, in main reftest.runTests(manifest, options, cmdlineArgs) File "/builds/tegra-022/test/build/tests/reftest/runreftest.py", line 135, in runTests timeout=options.timeout + 30.0) File "/builds/tegra-022/test/build/tests/reftest/automation.py", line 1049, in runApp status = self.waitForFinish(proc, utilityPath, timeout, maxTime, startTime, debuggerInfo, symbolsPath) File "/builds/tegra-022/test/build/tests/reftest/remoteautomation.py", line 81, in waitForFinish "allowed maximum time of %d seconds" % (self.lastTestSeen, int(maxTime)) TypeError: int() argument must be a string or a number, not 'NoneType' Looking into this further, I see that we never define maxTime. I would like to see how this is different than timeout and how we can set this in general.
Should be fixed by bug 809753. I'll file a bug about fixing our maxTime vs timeout story :-)
(In reply to Ed Morley [UTC+0; email:edmorley@moco] from comment #1) > Should be fixed by bug 809753. Notably https://hg.mozilla.org/integration/mozilla-inbound/rev/99216975f48b
we should remove maxTime, or implement it. Right now I don't see a method to implement it.
(In reply to Joel Maher (:jmaher) from comment #3) > we should remove maxTime, or implement it. Right now I don't see a method > to implement it. It's used on B2G and/or desktop on some suites aiui. This is what I meant by fixing our timeout vs MaxTime story. timeout = time without output maxTime = maximum duration of the run Both are useful & both are something we should be handling in the harness, rather than letting buildbot kill off jobs itself because they've hung - since we then don't get a TBPL-parsable error message and/or the chance to dump some more debugging info from the harness itself.